Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert yieldy behavior for non-use Suspense (in Flight, too) #25541

Closed
wants to merge 1 commit into from
Closed

Revert yieldy behavior for non-use Suspense (in Flight, too) #25541

wants to merge 1 commit into from

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 23, 2022

Same as #25537 but for Flight.

I was going to wait to do this later because the temporary implementation of async components uses some of the same code that non-used wakables do, but it's not so bad. I just had to inline one bit of code, which we'll remove when we unify the implementation with use.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 23, 2022
@sizebot
Copy link

sizebot commented Oct 23, 2022 •
edited
Loading

Comparing: cce18e3...cefba1b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.67 kB 135.67 kB = 43.46 kB 43.46 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 154.31 kB 154.31 kB = 49.20 kB 49.20 kB
facebook-www/ReactDOM-prod.classic.js = 493.82 kB 493.82 kB = 87.89 kB 87.89 kB
facebook-www/ReactDOM-prod.modern.js = 479.08 kB 479.08 kB = 85.71 kB 85.71 kB
facebook-www/ReactDOMForked-prod.classic.js = 493.82 kB 493.82 kB = 87.89 kB 87.89 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js +2.14% 13.07 kB 13.35 kB +1.08% 4.81 kB 4.86 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 54.85 kB 53.70 kB = 13.46 kB 13.07 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 54.85 kB 53.70 kB = 13.46 kB 13.07 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js = 52.03 kB 50.87 kB = 12.99 kB 12.60 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server-flight.production.min.js +2.14% 13.07 kB 13.35 kB +1.08% 4.81 kB 4.86 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js +1.89% 33.55 kB 34.18 kB +0.85% 8.48 kB 8.55 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js +1.88% 33.63 kB 34.26 kB +0.85% 8.51 kB 8.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +1.28% 21.78 kB 22.06 kB +0.68% 7.70 kB 7.75 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +1.27% 21.98 kB 22.26 kB +0.91% 7.78 kB 7.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.25% 22.16 kB 22.44 kB +0.71% 7.79 kB 7.84 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.30% 59.09 kB 59.27 kB = 14.51 kB 14.28 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.24% 86.05 kB 86.26 kB = 20.88 kB 20.65 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +0.24% 72.06 kB 72.24 kB = 17.90 kB 17.67 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +0.24% 72.12 kB 72.29 kB = 17.92 kB 17.69 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.22% 81.90 kB 82.08 kB = 20.63 kB 20.38 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.22% 83.09 kB 83.27 kB = 20.68 kB 20.44 kB
facebook-relay/flight/ReactFlightNativeRelayServer-prod.js = 26.46 kB 26.40 kB = 6.38 kB 6.37 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 78.79 kB 77.64 kB = 19.58 kB 19.18 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 78.79 kB 77.64 kB = 19.58 kB 19.18 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 81.54 kB 80.35 kB = 19.78 kB 19.35 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 81.54 kB 80.35 kB = 19.78 kB 19.35 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 77.60 kB 76.45 kB = 19.52 kB 19.11 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 77.60 kB 76.45 kB = 19.52 kB 19.11 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 54.85 kB 53.70 kB = 13.46 kB 13.07 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 54.85 kB 53.70 kB = 13.46 kB 13.07 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js = 52.03 kB 50.87 kB = 12.99 kB 12.60 kB

Generated by 🚫 dangerJS against cefba1b

@acdlite acdlite marked this pull request as ready for review October 23, 2022 03:02
@acdlite acdlite mentioned this pull request Oct 23, 2022
Closed
@acdlite
Revert yieldy behavior for non-use Suspense (in Flight, too)
cefba1b 
Same as facebook#25537 but for Flight.

I was going to wait to do this later because the temporary
implementation of async components uses some of the same code that
non-used wakables do, but it's not so bad. I just had to inline one bit
of code, which we'll remove when we unify the implementation with `use`.
@acdlite acdlite force-pushed the revert-yieldy-non-use-flight branch from b1a9296 to cefba1b Compare October 23, 2022 05:09
@acdlite
Copy link
Collaborator Author

acdlite commented Oct 24, 2022

Closed by 7fc3eef

@acdlite acdlite closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @sebmarkbage @facebook-github-bot