Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigial Suspense batching logic #25861

Merged

Commits on Jan 4, 2023

  1. Remove vestigial Suspense batching logic

    This code was originally added in the old ExpirationTime implementation
    of Suspense. The idea is that if multiple updates suspend inside the
    same Suspense boundary, and both of them resolve, we should render both
    results in the same batch, to reduce jank.
    
    This was an incomplete idea, though. We later discovered a stronger
    requirement — once we show a fallback, we cannot fill in that fallback
    without completing _all_ the updates that were previously skipped over.
    Otherwise you get tearing. This was fixed by facebook#18411, then we
    discovered additional related flaws that were addressed in facebook#24685. See 
    those PR descriptions for additional context.
    
    So I believe this older code is no longer necessary.
    acdlite committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    652533d View commit details
    Browse the repository at this point in the history