fix function type for flow #25965
Merged
fix function type for flow #25965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
CI breakage seems to be unrelated. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
These files fail CI `yarn_flow`. DiffTrain build for [2619886](2619886) [View git log for this commit](https://github.com/facebook/react/commits/2619886ac0f1d41c9b361d82f069f9ed682321ff)
afc163
reviewed
Jan 6, 2023
| @@ -15,7 +15,7 @@ function generateArray(size) { | |||
|
|
|||
| const arr = generateArray(50000); | |||
|
|
|||
| export default function LargeSubtree() { | |||
| export default function LargeSubtree(): React.Node { | |||
There was a problem hiding this comment.
|
ok please don't send me any more emails
afc163 ***@***.***>于令和5年1月6日周五下午4:46写道：
***@***.**** commented on this pull request.
------------------------------
In packages/react-devtools-shell/src/perf-regression/apps/LargeSubtree.js
<#25965 (comment)>:
> @@ -15,7 +15,7 @@ function generateArray(size) {
const arr = generateArray(50000);
-export default function LargeSubtree() {
+export default function LargeSubtree(): React.Node {
React.Node or React.ReactNode ?
—
Reply to this email directly, view it on GitHub
<#25965 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANEU5MP3LEBQ6TSUXJZOBFDWQ6WUVANCNFSM6AAAAAATSKGGPE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Ngat hock Tang
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files fail CI
yarn_flow.