Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] fix local build for extension #26067

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

mondaychen
Copy link
Contributor

Summary

resolves #26051

After we upgrade to Manifest V3, the browser no longer allow us to run eval within the extension. It's not a problem for prod build, but for dev build, webpack has been using eval to inject the source map for devtool. This PR changes it to an alternative method.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 27, 2023
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mondaychen mondaychen merged commit 78c4bec into facebook:main Jan 27, 2023
github-actions bot pushed a commit that referenced this pull request Jan 27, 2023
## Summary

resolves #26051

After we upgrade to Manifest V3, the browser no longer allow us to run
`eval` within the extension. It's not a problem for prod build, but for
dev build, webpack has been using eval to inject the source map for
devtool. This PR changes it to an alternative method.

DiffTrain build for [78c4bec](78c4bec)
[View git log for this commit](https://github.com/facebook/react/commits/78c4bec207795e718b5f4acc48ade19c8b94bf1f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevTools Bug]: Can not work on devtools, instructions lead to error
3 participants