Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not throw for children of iframe or object #26458

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Should not throw for children of iframe or object #26458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-dom-bindings/src/client/ReactDOMComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,6 @@ export function setInitialProperties(
listenToNonDelegatedEvent('close', domElement);
props = rawProps;
break;
case 'iframe':
case 'object':
case 'embed':
if (
rawProps.children != null ||
Expand All @@ -608,6 +606,9 @@ export function setInitialProperties(
'use `dangerouslySetInnerHTML`.',
);
}
// eslint-disable-next-line no-fallthrough
case 'iframe':
case 'object':
// We listen to this event in case to ensure emulated bubble
// listeners still fire for the load event.
listenToNonDelegatedEvent('load', domElement);
Expand Down