[Fiber] InvokeGuardedCallback without metaprogramming #26569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: fdad813...8e9965d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gnoff
force-pushed
the
icg-without-metaprogramming
branch
from
3b02d97 to
5713b4d
Compare
gnoff
force-pushed
the
icg-without-metaprogramming
branch
from
5713b4d to
9f3a8f7
Compare
harrygz889
reviewed
Apr 9, 2023
| }; | ||
| } | ||
| // We only get here if we are in an environment that either does not support the browser | ||
| // variant or we had trouble getting the brwoser to emit the error. |
There was a problem hiding this comment.
Suggested change
| // variant or we had trouble getting the brwoser to emit the error. | |
| // variant or we had trouble getting the browser to emit the error. |
gnoff
force-pushed
the
icg-without-metaprogramming
branch
2 times, most recently
from
86976ff to
87f74c6
Compare
sebmarkbage
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
We probably shouldn't rely on window/document changing anyway. I suspect this won't be the last time we do this. In fact, I'm kind of doing it now in my draft PR.
I feel like it's safe for us to assume that window/document won't change during the life time and it's up to us to rewrite our tests to not rely on it.
The implementation is largely unchanged except that the branching for when to use thebrowser specific override in dev is done in the function execution rather than by replacing the function implementation upon module evaluation.
gnoff
force-pushed
the
icg-without-metaprogramming
branch
from
87f74c6 to
8e9965d
Compare
kassens
pushed a commit
that referenced
this pull request
Apr 21, 2023
InvokeGuardedCallback is now implemented with the browser fork done at error-time rather than module-load-time. Originally it also tried to freeze the window/document references to avoid mismatches in prototype chains when testing React in different documents however we have since updated our tests to not do this and it was a test only feature so I removed it.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
InvokeGuardedCallback is now implemented with the browser fork done at error-time rather than module-load-time. Originally it also tried to freeze the window/document references to avoid mismatches in prototype chains when testing React in different documents however we have since updated our tests to not do this and it was a test only feature so I removed it.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
InvokeGuardedCallback is now implemented with the browser fork done at error-time rather than module-load-time. Originally it also tried to freeze the window/document references to avoid mismatches in prototype chains when testing React in different documents however we have since updated our tests to not do this and it was a test only feature so I removed it. DiffTrain build for commit cc93a85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvokeGuardedCallback is now implemented with the browser fork done at error-time rather than module-load-time. Originally it also tried to freeze the window/document references to avoid mismatches in prototype chains when testing React in different documents however we have since updated our tests to not do this and it was a test only feature so I removed it.