Remove initOption special case #26595
Merged
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: ac43bf6...9159240 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
commented
Apr 11, 2023
| @@ -888,7 +888,7 @@ describe('ReactDOMSelect', () => { | |||
| </select>, | |||
| ); | |||
|
|
|||
| expect(node.value).toBe(''); | |||
| expect(node.value).toBe('A Symbol!'); | |||
| }); | |||
|
|
|||
| it('treats initial Symbol defaultValue as an empty string', () => { | |||
There was a problem hiding this comment.
These defaultValue tests are bad tests because they test what the current selection is with the first option, but since the first option is selected when there is no match, they don't fail if it just doesn't match.
sebmarkbage
force-pushed
the
rminitoption
branch
from
0d9515b to
11963c4
Compare
sebmarkbage
commented
Apr 11, 2023
| @@ -9,6 +9,12 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| // Fix JSDOM. setAttribute is supposed to throw on things that can't be implicitly toStringed. | |||
There was a problem hiding this comment.
This is a little hacky but it's making the TemporalLike objects throw without us explicitly tostringing in React which we shouldn't need to, since there can be Trusted Types involved. Maybe a newer JSDOM would help.
There was a problem hiding this comment.
Can we unset this in an afterAll so it's just for this file? Or move it to setupEnvironment.js (or setupTests.js? I don't know what the difference is)?
There was a problem hiding this comment.
Isn't it a new document for every test suite anyway? I think we rely on that anyway.
I wanted to colocate this fix so that we can choose to fix the tests instead if we need to.
sebmarkbage
force-pushed
the
rminitoption
branch
2 times, most recently
from
85bfc2a to
f5824b9
Compare
sebmarkbage
force-pushed
the
rminitoption
branch
from
f5824b9 to
9159240
Compare
sophiebits
approved these changes
Apr 11, 2023
| @@ -9,6 +9,12 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| // Fix JSDOM. setAttribute is supposed to throw on things that can't be implicitly toStringed. | |||
There was a problem hiding this comment.
Can we unset this in an afterAll so it's just for this file? Or move it to setupEnvironment.js (or setupTests.js? I don't know what the difference is)?
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
This traces back to #6449 and then another before that. I think that back then we favored the property over the attribute, and setting the property wouldn't be enough. However, the default path for these are now using attributes if we don't special case it. So we don't need it. The only difference is that we currently have a divergence for symbol/function behavior between controlled values that use the getToStringValue helpers which treat them as empty string, where as everywhere else they're treated as null/missing. Since this comes with a warning and is a weird error case, it's probably fine to change. DiffTrain build for [343a45f](343a45f)
kassens
added a commit
to kassens/react
that referenced
this pull request
Apr 17, 2023
This reverts commit 343a45f.
kassens
pushed a commit
to kassens/react
that referenced
this pull request
Apr 21, 2023
, facebook#26595, facebook#26596, facebook#26627 - Refactor some controlled component stuff (facebook#26573) - Don't update textarea defaultValue and input checked unnecessarily (facebook#26580) - Diff properties in the commit phase instead of generating an update payload (facebook#26583) - Move validation of text nesting into ReactDOMComponent (facebook#26594) - Remove initOption special case (facebook#26595) - Use already extracted values instead of reading off props for controlled components (facebook#26596) - Fix input tracking bug (facebook#26627)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
- Refactor some controlled component stuff (#26573) - Don't update textarea defaultValue and input checked unnecessarily (#26580) - Diff properties in the commit phase instead of generating an update payload (#26583) - Move validation of text nesting into ReactDOMComponent (#26594) - Remove initOption special case (#26595) - Use already extracted values instead of reading off props for controlled components (#26596) - Fix input tracking bug (#26627) DiffTrain build for [ded4a78](ded4a78)
kassens
pushed a commit
that referenced
this pull request
Apr 21, 2023
- Refactor some controlled component stuff (#26573) - Don't update textarea defaultValue and input checked unnecessarily (#26580) - Diff properties in the commit phase instead of generating an update payload (#26583) - Move validation of text nesting into ReactDOMComponent (#26594) - Remove initOption special case (#26595) - Use already extracted values instead of reading off props for controlled components (#26596) - Fix input tracking bug (#26627)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This traces back to facebook#6449 and then another before that. I think that back then we favored the property over the attribute, and setting the property wouldn't be enough. However, the default path for these are now using attributes if we don't special case it. So we don't need it. The only difference is that we currently have a divergence for symbol/function behavior between controlled values that use the getToStringValue helpers which treat them as empty string, where as everywhere else they're treated as null/missing. Since this comes with a warning and is a weird error case, it's probably fine to change.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This traces back to #6449 and then another before that. I think that back then we favored the property over the attribute, and setting the property wouldn't be enough. However, the default path for these are now using attributes if we don't special case it. So we don't need it. The only difference is that we currently have a divergence for symbol/function behavior between controlled values that use the getToStringValue helpers which treat them as empty string, where as everywhere else they're treated as null/missing. Since this comes with a warning and is a weird error case, it's probably fine to change. DiffTrain build for commit 343a45f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This traces back to #6449 and then another before that.
I think that back then we favored the property over the attribute, and setting the property wouldn't be enough. However, the default path for these are now using attributes if we don't special case it. So we don't need it.
The only difference is that we currently have a divergence for symbol/function behavior between controlled values that use the getToStringValue helpers which treat them as empty string, where as everywhere else they're treated as null/missing.
Since this comes with a warning and is a weird error case, it's probably fine to change.