Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React DevTools 4.27.4 -> 4.27.5 #26637

Merged
merged 1 commit into from
Apr 17, 2023
Merged

React DevTools 4.27.4 -> 4.27.5 #26637

merged 1 commit into from
Apr 17, 2023

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Apr 17, 2023

Full list of changes (not everything included in changelog):

  • refactor[devtools]: copy to clipboard only on frontend side (hoxyq in #26604)
  • Provide icon to edge devtools. (harrygz889 in #26543)
  • [BE] move shared types & constants to consolidated locations (mondaychen in #26572)
  • remove backend dependency from the global hook (mondaychen in #26563)
  • Replace deprecated new-window with webContents.setWindowOpenHandler() (Willie-Boy in #26559)
  • DevTools: Inline references to fiber flags (acdlite in #26542)
  • refactor[devtools]: forbid editing class instances in props (hoxyq in #26522)
  • Move update scheduling to microtask (acdlite in #26512)
  • Remove unnecessary CIRCLE_CI_API_TOKEN checks (mondaychen in #26499)
  • browser extension: improve script injection logic (mondaychen in #26492)
  • [flow] make Flow suppressions explicit on the error (kassens in #26487)

@hoxyq hoxyq requested a review from mondaychen April 17, 2023 15:01
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 17, 2023
mondaychen
mondaychen suggested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mondaychen mondaychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two other commits I believe we should include in the changelog:

Bugfix

[DevTools] Replace deprecated new-window with webContents.setWindowOpenHandler() (#26559)
(We can reword to "fix external link behavior in the standalone app")

Other

[DevTools] improve script injection logic in browser extension (#26492)

@hoxyq
Copy link
Contributor Author

hoxyq commented Apr 17, 2023

There are two other commits I believe we should include in the changelog:

Bugfix

[DevTools] Replace deprecated new-window with webContents.setWindowOpenHandler() (#26559) (We can reword to "fix external link behavior in the standalone app")

Other

[DevTools] improve script injection logic in browser extension (#26492)

Fixed, thanks

@hoxyq hoxyq merged commit 77d3b02 into facebook:main Apr 17, 2023
@hoxyq hoxyq deleted the release/4.27.5 branch April 17, 2023 16:42
kassens pushed a commit to kassens/react that referenced this pull request Apr 17, 2023
@hoxyq @kassens
React DevTools 4.27.4 -> 4.27.5 (facebook#26637)
253e889 
Full list of changes (not everything included in changelog):
* refactor[devtools]: copy to clipboard only on frontend side
([hoxyq](https://github.com/hoxyq) in
[facebook#26604](facebook#26604))
* Provide icon to edge devtools.
([harrygz889](https://github.com/harrygz889) in
[facebook#26543](facebook#26543))
* [BE] move shared types & constants to consolidated locations
([mondaychen](https://github.com/mondaychen) in
[facebook#26572](facebook#26572))
* remove backend dependency from the global hook
([mondaychen](https://github.com/mondaychen) in
[facebook#26563](facebook#26563))
* Replace deprecated `new-window` with
`webContents.setWindowOpenHandler()`
([Willie-Boy](https://github.com/Willie-Boy) in
[facebook#26559](facebook#26559))
* DevTools: Inline references to fiber flags
([acdlite](https://github.com/acdlite) in
[facebook#26542](facebook#26542))
* refactor[devtools]: forbid editing class instances in props
([hoxyq](https://github.com/hoxyq) in
[facebook#26522](facebook#26522))
* Move update scheduling to microtask
([acdlite](https://github.com/acdlite) in
[facebook#26512](facebook#26512))
* Remove unnecessary CIRCLE_CI_API_TOKEN checks
([mondaychen](https://github.com/mondaychen) in
[facebook#26499](facebook#26499))
* browser extension: improve script injection logic
([mondaychen](https://github.com/mondaychen) in
[facebook#26492](facebook#26492))
* [flow] make Flow suppressions explicit on the error
([kassens](https://github.com/kassens) in
[facebook#26487](facebook#26487))
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq @AndyPengc12
React DevTools 4.27.4 -> 4.27.5 (facebook#26637)
62637a7 
Full list of changes (not everything included in changelog):
* refactor[devtools]: copy to clipboard only on frontend side
([hoxyq](https://github.com/hoxyq) in
[facebook#26604](facebook#26604))
* Provide icon to edge devtools.
([harrygz889](https://github.com/harrygz889) in
[facebook#26543](facebook#26543))
* [BE] move shared types & constants to consolidated locations
([mondaychen](https://github.com/mondaychen) in
[facebook#26572](facebook#26572))
* remove backend dependency from the global hook
([mondaychen](https://github.com/mondaychen) in
[facebook#26563](facebook#26563))
* Replace deprecated `new-window` with
`webContents.setWindowOpenHandler()`
([Willie-Boy](https://github.com/Willie-Boy) in
[facebook#26559](facebook#26559))
* DevTools: Inline references to fiber flags
([acdlite](https://github.com/acdlite) in
[facebook#26542](facebook#26542))
* refactor[devtools]: forbid editing class instances in props
([hoxyq](https://github.com/hoxyq) in
[facebook#26522](facebook#26522))
* Move update scheduling to microtask
([acdlite](https://github.com/acdlite) in
[facebook#26512](facebook#26512))
* Remove unnecessary CIRCLE_CI_API_TOKEN checks
([mondaychen](https://github.com/mondaychen) in
[facebook#26499](facebook#26499))
* browser extension: improve script injection logic
([mondaychen](https://github.com/mondaychen) in
[facebook#26492](facebook#26492))
* [flow] make Flow suppressions explicit on the error
([kassens](https://github.com/kassens) in
[facebook#26487](facebook#26487))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@hoxyq
React DevTools 4.27.4 -> 4.27.5 (#26637)
8537561 
Full list of changes (not everything included in changelog):
* refactor[devtools]: copy to clipboard only on frontend side
([hoxyq](https://github.com/hoxyq) in
[#26604](#26604))
* Provide icon to edge devtools.
([harrygz889](https://github.com/harrygz889) in
[#26543](#26543))
* [BE] move shared types & constants to consolidated locations
([mondaychen](https://github.com/mondaychen) in
[#26572](#26572))
* remove backend dependency from the global hook
([mondaychen](https://github.com/mondaychen) in
[#26563](#26563))
* Replace deprecated `new-window` with
`webContents.setWindowOpenHandler()`
([Willie-Boy](https://github.com/Willie-Boy) in
[#26559](#26559))
* DevTools: Inline references to fiber flags
([acdlite](https://github.com/acdlite) in
[#26542](#26542))
* refactor[devtools]: forbid editing class instances in props
([hoxyq](https://github.com/hoxyq) in
[#26522](#26522))
* Move update scheduling to microtask
([acdlite](https://github.com/acdlite) in
[#26512](#26512))
* Remove unnecessary CIRCLE_CI_API_TOKEN checks
([mondaychen](https://github.com/mondaychen) in
[#26499](#26499))
* browser extension: improve script injection logic
([mondaychen](https://github.com/mondaychen) in
[#26492](#26492))
* [flow] make Flow suppressions explicit on the error
([kassens](https://github.com/kassens) in
[#26487](#26487))

DiffTrain build for commit 77d3b02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondaychen mondaychen mondaychen approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxyq @mondaychen @facebook-github-bot