Add stub for experimental_useFormStatus #26719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wires up, but does not yet implement, an experimental hook called useFormStatus. The hook is imported from React DOM, not React, because it represents DOM-specific state — its return type includes FormData as one of its fields. Other renderers that implement similar methods would use their own renderer-specific types. The API is prefixed and only available in the experimental channel. It can only be used from client (browser, SSR) components, not Server Components.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 5e5342b...663e13a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
approved these changes
Apr 24, 2023
sebmarkbage
approved these changes
Apr 24, 2023
sebmarkbage
reviewed
Apr 24, 2023
| @@ -31,6 +31,7 @@ export { | |||
| unstable_createEventHandle, | |||
| unstable_renderSubtreeIntoContainer, | |||
| unstable_runWithPriority, // DO NOT USE: Temporarily exposed to migrate off of Scheduler.runWithPriority. | |||
| useFormStatus as experimental_useFormStatus, | |||
There was a problem hiding this comment.
Just noticing that the form flag is on in www but not the async transitions one so it's kind of a useless combination for this export.
There was a problem hiding this comment.
Yeah I intentionally kept the async one off because it affects error handling behavior even in regular, sync useTransition. Should we turn enableFormActions off too?
There was a problem hiding this comment.
Yea, let's do that for now.
There was a problem hiding this comment.
If we turn them on we have to also update this to get the right external runtime from experimental or make an fb build.
https://github.com/facebook/react/blob/main/.github/workflows/commit_artifacts.yml#L137-L138
There was a problem hiding this comment.
Ok I opened a separate PR where we can discuss: #26721
acdlite
added a commit
to acdlite/react
that referenced
this pull request
May 7, 2023
This was an oversight when I set up the hook in facebook#26719
acdlite
added a commit
that referenced
this pull request
May 7, 2023
This was an oversight when I set up the hook in #26719.
6 tasks
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This wires up, but does not yet implement, an experimental hook called useFormStatus. The hook is imported from React DOM, not React, because it represents DOM-specific state — its return type includes FormData as one of its fields. Other renderers that implement similar methods would use their own renderer-specific types. The API is prefixed and only available in the experimental channel. It can only be used from client (browser, SSR) components, not Server Components.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This was an oversight when I set up the hook in facebook#26719.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This wires up, but does not yet implement, an experimental hook called useFormStatus. The hook is imported from React DOM, not React, because it represents DOM-specific state — its return type includes FormData as one of its fields. Other renderers that implement similar methods would use their own renderer-specific types. The API is prefixed and only available in the experimental channel. It can only be used from client (browser, SSR) components, not Server Components. DiffTrain build for commit 919620b.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up, but does not yet implement, an experimental hook called useFormStatus. The hook is imported from React DOM, not React, because it represents DOM-specific state — its return type includes FormData as one of its fields. Other renderers that implement similar methods would use their own renderer-specific types.
The API is prefixed and only available in the experimental channel.
It can only be used from client (browser, SSR) components, not Server Components.