Fix: update other radios tracked value in one group when one is updated to be checked #27024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #26876, which is caused by not updating tracked values. Please see here for the investigation details.
The root is, when one radio is changed to be checked (by updating the
checked
prop), the previously checked one won't update its tracked value (will be still'true'
) if it's one of the previous siblings.How did you test this change?
Testing Steps (refer to but not exactly follow the steps of reproduction):
checked
props to make radio1 unchecked, and radio2 checked.checked
props to make radio1 checked, and radio2 unchecked.onChange
handler should be called after fixing the issue.Any feedback and suggestions will be appreciated. cc @eps1lon @sebmarkbage @acdlite