Add referrerPolicy option to ReactDOM.preload()
#27096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 0a36064...24e2703 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
requested changes
Jul 12, 2023
Comment on lines
3588
to
3594
| ReactDOM.preload('rp', { | ||
| as: 'image', | ||
| imageSrcSet: 'rpsrcset', | ||
| imageSizes: 'rpsizes', | ||
| referrerPolicy: 'no-referrer', | ||
| }); | ||
|
|
There was a problem hiding this comment.
Can we just make a new test. The preload calls in this test are designed to demonstrate the keying behavior and throwing the ancillary rp preload here is going to maybe be confusing in the future. There is probably already a more generic test acutally that you can just add referrer policy to and just modify the assertions
There was a problem hiding this comment.
I created a new test in 24e2703
gnoff
approved these changes
Jul 12, 2023
styfle
added a commit
to vercel/next.js
that referenced
this pull request
Jul 13, 2023
### React upstream changes - facebook/react#27096 - facebook/react#27069 - facebook/react#27033 - facebook/react#27061 - facebook/react#27030 - facebook/react#27056
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 14, 2023
- Depends on facebook/react#27096 - Fixes #43134 - Closes NEXT-811 - Closes NEXT-846
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
DiffTrain build for commit 9377e10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We started using
ReactDOM.preload()in Next.js but found thereferrerPolicyoption was missing.<preload>fornext/imagein App Router vercel/next.js#52425How did you test this change?