Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-devtools] Update element inspection timeout to 60 seconds #27182

Closed

Conversation

dunnbobcat
Copy link

@dunnbobcat dunnbobcat commented Aug 2, 2023

Summary

React DevTools can become nigh unusable on particularly complex/large pages. I consistently hit this 5 second timeout when trying to inspect elements on certain pages. This means I can't inspect props and state, trigger suspense, and so on.

I'm more than happy to wait longer for the React DevTools to inspect an element, so long as it eventually works. A cursory Google search turns up other people hitting this problem, too: https://stackoverflow.com/questions/70897741/react-devtools-timeout-unable-to-inspect-element

As a first pass, this changes the timeout to 60 seconds instead of 5.

How did you test this change?

Ran yarn, yarn test, yarn linc in the repo root.

React DevTools can become nigh unusable on particularly complex/large pages. I consistently hit this 5 second timeout when trying to inspect elements on my pages. This means I can't inspect props and state, trigger suspense, and so on.

I'm more than happy to wait longer for the React DevTools to inspect an element, so long as it eventually works. A cursory Google search turns up other people hitting this problem, too: https://stackoverflow.com/questions/70897741/react-devtools-timeout-unable-to-inspect-element

As a first pass, this changes the timeout to 60 seconds instead of 5.
@hoxyq
Copy link
Contributor

hoxyq commented Aug 2, 2023

Hey @dunnbobcat, thanks for contributing!

Have you tested that this really fixes the problem though? You can run yarn build:chrome:local from /packages/react-devtools-extensions to create a local build and test it.

From my observations, most timeout cases are coming from dead service worker, this is mentioned in #27119. I am currently working on this, so things should get more reliable soon.

I am happy to increase this timeout (to 10 seconds maybe), but I don't think that this really solves the problem.

Copy link

github-actions bot commented Apr 8, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 8, 2024
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants