refactor[ci/build]: support FB_WWW_BROWSER_SCRIPT bundle type #27664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
commented
Nov 8, 2023
Comment on lines
+172
to
+174
| if (fileName !== 'unstable_server-external-runtime.js') { | ||
| fs.renameSync(filePath, filePath.replace('.js', '.classic.js')); | ||
| } |
There was a problem hiding this comment.
We don't have access to bundle types at this point. Instead of relying on fileName I can parse bundles array and try finding everything what has bundleType FB_WWW_BROWSER_SCRIPT, if that seems like a better option
|
This would require more changes, than I've expected. Since we have only 1 artifact with Closing this in favour of #27665. |
hoxyq
added a commit
that referenced
this pull request
Nov 9, 2023
…es (#27665) Instead of #27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in #27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
…es (#27665) Instead of #27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in #27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier. DiffTrain build for [78c71bc](78c71bc)
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
…es (#27665) Instead of facebook/react#27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in facebook/react#27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier. DiffTrain build for [78c71bc545bf5c0fdeedc023b69fafe05d988067](facebook/react@78c71bc)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…es (facebook#27665) Instead of facebook#27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in facebook#27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #26446.
Fixes 2 issues:
unstable_server-external-runtime.jsintofacebook-wwwwhen committing artifacts to Meta's monorepo.yarn build: you will not getbuild/facebook-www/unstable_server-external-runtime.jsin this case.build/oss-stable/react-dom/unstable_server-external-runtime.jsis actually included intoreact-domnpm package, we ship sourcemaps for it. We don't need sourcemaps for Meta's versions of these artifacts, though, it should be built separately with a different bundle type.unstable_server-external-runtime.jsdoesn't have any effect on thehashthat is created here https://github.com/facebook/react/blob/main/scripts/rollup/build-all-release-channels.js#L165-L173 or herehttps://github.com/facebook/react/blob/main/scripts/rollup/build-all-release-channels.js#L239-L247. I can double-check this, but it probably means that if only sources of this artifact change, it won't create a new react version identifier, which is based on
hash.