-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions and workflows #27760
GitHub actions and workflows #27760
Conversation
Comparing: bbb9cb1...0f1ec18 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Thanks for the start here @robandpdx! For the cases of running more tests, I think you might want to search for |
Since we already run Circle and GH Actions in parallel, would it make sense to try to port jobs in smaller chunks? E.g. I think we could probably move the flow check job or other parts over in chunks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above, maybe split this up? I think we can at least migrate some of the jobs over separately which might be easier to review and land incremental gains.
@kassens Sure, I'll break this up into a PR for each workflow. |
There's a few dependencies where some things depend on the build, but most of the jobs are - I think - without dependencies. |
1f0ef6a
to
0f1ec18
Compare
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
This migration is now complete. Thanks for opening these PRs! |
Summary
This pull request converts the CircleCI workflows to GitHub actions workflows. Github Actions Importer was used to convert the workflows initially, then I edited them manually to correct errors in translation.
Issues
This job fails during the execution of
yarn build
within thepackages/react-devtools-extensions
directory with the following error:Errors
facebook/react/build_and_test -> yarn_test matrix
These jobs fail because tests are failing. These jobs seem to run a lot more tests than the same job in circleci and I don't know why.
facebook/react/build_and_test -> yarn_test_build matrix
These jobs fail because tests are failing. These jobs seem to run a lot more tests than the same job in circleci and I don't know why.
facebook/react/build_and_test -> run_devtools_e2e_tests
These jobs fail because tests are failing. These jobs seem to run a lot more tests than the same job in circleci and I don't know why.
facebook/react/devtools_regression_tests
The scripts that this workflow calls need to be modified.
facebook/react/publish_preleases
The scripts that this workflow calls need to be modified. Repo secrets need to be in place.
facebook/react/publish_preleases_nightly
The scripts that this workflow calls need to be modified. Repo secrets need to be in place.
How did you test this change?
I tested these changes in a forked repo.
https://fburl.com/workplace/f6mz6tmw