Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create warnings JS file for Meta #27786

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

kassens
Copy link
Member

@kassens kassens commented Dec 4, 2023

The WARNINGS file isn't picked up by the test dependency analyzer, this creates a JS version of the file that I think should work.

@kassens kassens requested review from noahlemen and jackpope December 4, 2023 17:26
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 4, 2023
@kassens
Copy link
Member Author

kassens commented Dec 4, 2023

NOTE: builds on #27785, so the diff view is a bit messed up here. You might only want to look at the second commit.

@kassens kassens merged commit 223db40 into facebook:main Dec 4, 2023
33 of 35 checks passed
@kassens kassens deleted the warnings-js branch December 4, 2023 18:33
kassens added a commit that referenced this pull request Dec 7, 2023
I recently added generation of this file in #27786, which builds the
file in CircleCI, but missed actually copying it to the facebook build
on GitHub Actions.

This adds the later.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
The `WARNINGS` file isn't picked up by the test dependency analyzer,
this creates a JS version of the file that I think should work.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
I recently added generation of this file in facebook#27786, which builds the
file in CircleCI, but missed actually copying it to the facebook build
on GitHub Actions.

This adds the later.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
The `WARNINGS` file isn't picked up by the test dependency analyzer,
this creates a JS version of the file that I think should work.

DiffTrain build for commit 223db40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants