[react-dom] Remove findDOMNode from OSS builds
#28267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
commented
Feb 7, 2024
Comment on lines
-705
to
-718
|
|
||
| it('supports drilling through to the DOM using findDOMNode', function() { | ||
| const ref = React.createRef(); | ||
| test(React.createElement(Inner, {name: 'foo', ref: ref}), 'DIV', 'foo'); | ||
| const node = ReactDOM.findDOMNode(ref.current); | ||
| expect(node).toBe(container.firstChild); | ||
| }); |
There was a problem hiding this comment.
I had trouble accessing internals from these tests so I just deleted the test. I can undo if there is pushback here but I'd argue that this no longer needs assertions since the API will be removed from public builds
gnoff
force-pushed
the
move-find-dom-node-to-internals
branch
from
85d4602 to
cd81c4a
Compare
rickhanlonii
approved these changes
Feb 7, 2024
| @@ -14,7 +14,6 @@ export { | |||
| createPortal, | |||
| createRoot, | |||
| hydrateRoot, | |||
| findDOMNode, | |||
There was a problem hiding this comment.
Should we provide an error like "findDOMNode has been removed, see react.dev/finddomnode for more info"?
gnoff
force-pushed
the
move-find-dom-node-to-internals
branch
3 times, most recently
from
9924aa7 to
e17f49f
Compare
Exposes `findDOMNode` on internals and updates tests to read from internals
gnoff
force-pushed
the
move-find-dom-node-to-internals
branch
from
e17f49f to
9928ca5
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
In the next major `findDOMNode` is being removed. This PR removes the API from the react-dom entrypoints for OSS builds and re-exposes the implementation as part of internals. `findDOMNode` is being retained for Meta builds and so all tests that currently use it will continue to do so by accessing it from internals. Once the replacement API ships in an upcoming minor any tests that were using this API incidentally can be updated to use the new API and any tests asserting `findDOMNode`'s behavior directly can stick around until we remove it entirely (once Meta has moved away from it) DiffTrain build for [9ad40b1](9ad40b1)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
In the next major `findDOMNode` is being removed. This PR removes the API from the react-dom entrypoints for OSS builds and re-exposes the implementation as part of internals. `findDOMNode` is being retained for Meta builds and so all tests that currently use it will continue to do so by accessing it from internals. Once the replacement API ships in an upcoming minor any tests that were using this API incidentally can be updated to use the new API and any tests asserting `findDOMNode`'s behavior directly can stick around until we remove it entirely (once Meta has moved away from it)
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next major
findDOMNodeis being removed. This PR removes the API from the react-dom entrypoints for OSS builds and re-exposes the implementation as part of internals.findDOMNodeis being retained for Meta builds and so all tests that currently use it will continue to do so by accessing it from internals. Once the replacement API ships in an upcoming minor any tests that were using this API incidentally can be updated to use the new API and any tests assertingfindDOMNode's behavior directly can stick around until we remove it entirely (once Meta has moved away from it)