Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy hydration mode #28440

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Feb 25, 2024

While Meta is still using legacy mode and we can't remove completely, Meta is not using legacy hydration so we should be able to remove that.

This is just the first step. Once removed, we can vastly simplify the DOMConfig for hydration.

This will have to be rebased when tests are upgraded.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 25, 2024
@sebmarkbage sebmarkbage force-pushed the removelegacyhydration branch 4 times, most recently from e4244f4 to 05f46b0 Compare February 25, 2024 23:16
@react-sizebot
Copy link

react-sizebot commented Feb 25, 2024

Comparing: dbfbfb3...da2de86

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.92 kB 175.94 kB = 54.94 kB 54.54 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.32 kB 172.42 kB = 54.06 kB 53.71 kB
facebook-www/ReactDOM-prod.classic.js = 595.14 kB 590.84 kB = 104.51 kB 103.76 kB
facebook-www/ReactDOM-prod.modern.js = 578.40 kB 574.36 kB = 101.53 kB 100.83 kB
test_utils/ReactAllWarnings.js Deleted 65.55 kB 0.00 kB Deleted 16.18 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.profiling.min.js = 182.78 kB 181.89 kB = 56.41 kB 56.08 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js = 182.13 kB 181.24 kB = 56.65 kB 56.30 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js = 180.13 kB 179.24 kB = 56.55 kB 56.23 kB
oss-experimental/react-dom/umd/react-dom.production.min.js = 173.11 kB 172.22 kB = 54.27 kB 54.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.32 kB 172.42 kB = 54.06 kB 53.71 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js = 185.68 kB 184.71 kB = 57.51 kB 57.20 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js = 185.60 kB 184.63 kB = 57.48 kB 57.17 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js = 186.39 kB 185.41 kB = 57.28 kB 56.92 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js = 186.31 kB 185.33 kB = 57.26 kB 56.89 kB
oss-stable/react-dom/umd/react-dom.production.min.js = 176.65 kB 175.67 kB = 55.18 kB 54.89 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js = 176.57 kB 175.60 kB = 55.15 kB 54.86 kB
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.92 kB 175.94 kB = 54.94 kB 54.54 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js = 176.84 kB 175.86 kB = 54.91 kB 54.52 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,656.62 kB 1,645.87 kB = 328.77 kB 327.48 kB
facebook-www/ReactDOM-profiling.modern.js = 607.87 kB 603.89 kB = 105.86 kB 105.14 kB
facebook-www/ReactDOM-dev.modern.js = 1,635.15 kB 1,624.40 kB = 324.24 kB 322.96 kB
facebook-www/ReactDOM-profiling.classic.js = 624.68 kB 620.44 kB = 108.87 kB 108.17 kB
facebook-www/ReactDOMTesting-prod.modern.js = 595.08 kB 591.04 kB = 105.69 kB 104.98 kB
facebook-www/ReactDOM-prod.modern.js = 578.40 kB 574.36 kB = 101.53 kB 100.83 kB
facebook-www/ReactDOMTesting-prod.classic.js = 609.92 kB 605.62 kB = 108.23 kB 107.48 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,687.70 kB 1,675.77 kB = 334.27 kB 332.91 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js = 124.84 kB 123.94 kB = 38.16 kB 37.88 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js = 124.81 kB 123.92 kB = 38.13 kB 37.86 kB
facebook-www/ReactDOM-dev.classic.js = 1,666.18 kB 1,654.25 kB = 329.73 kB 328.37 kB
facebook-www/ReactDOM-prod.classic.js = 595.14 kB 590.84 kB = 104.51 kB 103.76 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 123.06 kB 122.17 kB = 37.70 kB 37.43 kB
oss-experimental/react-dom/cjs/react-dom.profiling.js = 986.56 kB 979.06 kB = 219.83 kB 218.58 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js = 115.79 kB 114.90 kB = 35.83 kB 35.54 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js = 115.76 kB 114.87 kB = 35.81 kB 35.51 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 962.55 kB 955.04 kB = 216.68 kB 215.47 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,333.10 kB 1,322.70 kB = 293.72 kB 292.20 kB
oss-stable/react-dom/cjs/react-dom.profiling.js = 994.70 kB 986.94 kB = 220.95 kB 219.67 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.js = 994.67 kB 986.91 kB = 220.93 kB 219.64 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 114.02 kB 113.13 kB = 35.36 kB 35.08 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,378.83 kB 1,368.02 kB = 292.43 kB 290.91 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,315.30 kB 1,304.90 kB = 289.49 kB 287.92 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 944.62 kB 937.12 kB = 212.24 kB 211.00 kB
oss-stable/react-dom/cjs/react-dom.production.js = 952.76 kB 945.00 kB = 213.39 kB 212.14 kB
oss-stable-semver/react-dom/cjs/react-dom.production.js = 952.74 kB 944.97 kB = 213.36 kB 212.11 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,388.98 kB 1,377.20 kB = 294.07 kB 292.48 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,388.95 kB 1,377.17 kB = 294.04 kB 292.45 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,325.17 kB 1,313.82 kB = 291.10 kB 289.48 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,325.14 kB 1,313.80 kB = 291.07 kB 289.44 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js = 736.67 kB 730.14 kB = 159.36 kB 158.46 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js = 736.64 kB 730.12 kB = 159.33 kB 158.43 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 732.45 kB 725.93 kB = 158.49 kB 157.59 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js = 695.32 kB 688.80 kB = 151.94 kB 151.01 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js = 695.29 kB 688.77 kB = 151.91 kB 150.98 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 691.10 kB 684.58 kB = 151.07 kB 150.16 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 932.47 kB 923.43 kB = 198.41 kB 197.24 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 932.44 kB 923.40 kB = 198.38 kB 197.22 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 928.66 kB 919.61 kB = 197.57 kB 196.42 kB
test_utils/ReactAllWarnings.js Deleted 65.55 kB 0.00 kB Deleted 16.18 kB 0.00 kB

Generated by 🚫 dangerJS against da2de86

@sebmarkbage sebmarkbage merged commit 670d61b into facebook:main Mar 26, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
While Meta is still using legacy mode and we can't remove completely,
Meta is not using legacy hydration so we should be able to remove that.

This is just the first step. Once removed, we can vastly simplify the
DOMConfig for hydration.

This will have to be rebased when tests are upgraded.

DiffTrain build for [670d61b](670d61b)
sebmarkbage added a commit that referenced this pull request Mar 26, 2024
Build on top of #28440.

This lets us remove the path where updates are tracked on differences in
text.
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
Build on top of #28440.

This lets us remove the path where updates are tracked on differences in
text.

DiffTrain build for [84c84d7](84c84d7)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
While Meta is still using legacy mode and we can't remove completely,
Meta is not using legacy hydration so we should be able to remove that.

This is just the first step. Once removed, we can vastly simplify the
DOMConfig for hydration.

This will have to be rebased when tests are upgraded.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Build on top of facebook#28440.

This lets us remove the path where updates are tracked on differences in
text.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
While Meta is still using legacy mode and we can't remove completely,
Meta is not using legacy hydration so we should be able to remove that.

This is just the first step. Once removed, we can vastly simplify the
DOMConfig for hydration.

This will have to be rebased when tests are upgraded.

DiffTrain build for commit 670d61b.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Build on top of #28440.

This lets us remove the path where updates are tracked on differences in
text.

DiffTrain build for commit 84c84d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants