-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy hydration mode #28440
Merged
Merged
Remove legacy hydration mode #28440
+34
−675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Feb 25, 2024
sebmarkbage
force-pushed
the
removelegacyhydration
branch
4 times, most recently
from
February 25, 2024 23:16
e4244f4
to
05f46b0
Compare
sebmarkbage
force-pushed
the
removelegacyhydration
branch
from
February 25, 2024 23:25
05f46b0
to
a3f197f
Compare
acdlite
approved these changes
Feb 26, 2024
rickhanlonii
approved these changes
Feb 26, 2024
sebmarkbage
force-pushed
the
removelegacyhydration
branch
8 times, most recently
from
March 4, 2024 21:44
03ec26d
to
06a3ee6
Compare
sebmarkbage
force-pushed
the
removelegacyhydration
branch
from
March 26, 2024 21:22
06a3ee6
to
dcc2675
Compare
sebmarkbage
force-pushed
the
removelegacyhydration
branch
from
March 26, 2024 21:29
dcc2675
to
da2de86
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
While Meta is still using legacy mode and we can't remove completely, Meta is not using legacy hydration so we should be able to remove that. This is just the first step. Once removed, we can vastly simplify the DOMConfig for hydration. This will have to be rebased when tests are upgraded. DiffTrain build for [670d61b](670d61b)
sebmarkbage
added a commit
that referenced
this pull request
Mar 26, 2024
Build on top of #28440. This lets us remove the path where updates are tracked on differences in text.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
While Meta is still using legacy mode and we can't remove completely, Meta is not using legacy hydration so we should be able to remove that. This is just the first step. Once removed, we can vastly simplify the DOMConfig for hydration. This will have to be rebased when tests are upgraded.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Build on top of facebook#28440. This lets us remove the path where updates are tracked on differences in text.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
While Meta is still using legacy mode and we can't remove completely, Meta is not using legacy hydration so we should be able to remove that. This is just the first step. Once removed, we can vastly simplify the DOMConfig for hydration. This will have to be rebased when tests are upgraded. DiffTrain build for commit 670d61b.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Meta is still using legacy mode and we can't remove completely, Meta is not using legacy hydration so we should be able to remove that.
This is just the first step. Once removed, we can vastly simplify the DOMConfig for hydration.
This will have to be rebased when tests are upgraded.