Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump canary versions to v19-canary #28646

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Bump canary versions to v19-canary #28646

merged 1 commit into from
Mar 26, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 26, 2024

This bumps the canary versions to v19 to communicate that the next release will be a major. Once this lands, we can start merging breaking changes into main.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 26, 2024
rickhanlonii
rickhanlonii approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@kassens
Copy link
Member

kassens commented Mar 26, 2024

itshappening

@react-sizebot
Copy link

react-sizebot commented Mar 26, 2024 •
edited
Loading

Comparing: 738993d...be087de

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.93 kB 176.93 kB = 54.95 kB 54.95 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.33 kB 173.33 kB = 54.07 kB 54.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.15 kB 595.15 kB = 104.52 kB 104.52 kB
facebook-www/ReactDOM-prod.modern.js = 578.41 kB 578.41 kB = 101.54 kB 101.54 kB
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Generated by 🚫 dangerJS against be087de

@acdlite
Bump canary versions to v19-canary
be087de 
This bumps the canary versions to v19 to communicate that the next
release will be a major. Once this lands, we can start merging breaking
changes into `main`.
@acdlite acdlite merged commit 56efb2e into facebook:main Mar 26, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@acdlite
Bump canary versions to v19-canary (#28646)
a6c58b8 
This bumps the canary versions to v19 to communicate that the next
release will be a major. Once this lands, we can start merging breaking
changes into `main`.

DiffTrain build for [56efb2e](56efb2e)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@acdlite @AndyPengc12
Bump canary versions to v19-canary (facebook#28646)
d1ddb11 
This bumps the canary versions to v19 to communicate that the next
release will be a major. Once this lands, we can start merging breaking
changes into `main`.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@acdlite
Bump canary versions to v19-canary (#28646)
9ba136d 
This bumps the canary versions to v19 to communicate that the next
release will be a major. Once this lands, we can start merging breaking
changes into `main`.

DiffTrain build for commit 56efb2e.
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acdlite @kassens @react-sizebot @rickhanlonii @facebook-github-bot