Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove zoom from special cases list" #28673

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

sophiebits
Copy link
Collaborator

Reverts #26631

This got specced: w3c/csswg-drafts#9699

I left msZoom because it seems plausible someone will still be using it for backwards compat.

@sophiebits sophiebits requested a review from rickhanlonii March 29, 2024 16:32
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 29, 2024
@react-sizebot
Copy link

Comparing: a73c345...c77686b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.69 kB 176.70 kB +0.01% 54.93 kB 54.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.09 kB 173.11 kB +0.02% 53.94 kB 53.95 kB
facebook-www/ReactDOM-prod.classic.js = 592.87 kB 592.88 kB = 104.00 kB 104.01 kB
facebook-www/ReactDOM-prod.modern.js = 574.56 kB 574.57 kB = 101.02 kB 101.03 kB
test_utils/ReactAllWarnings.js Deleted 65.05 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 65.05 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Generated by 🚫 dangerJS against c77686b

@sophiebits sophiebits merged commit 19c7c29 into main Mar 29, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
Reverts #26631

This got specced: w3c/csswg-drafts#9699

I left msZoom because it seems plausible someone will still be using it
for backwards compat.

DiffTrain build for [19c7c29](19c7c29)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Reverts facebook#26631

This got specced: w3c/csswg-drafts#9699

I left msZoom because it seems plausible someone will still be using it
for backwards compat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants