Align React Native OSS/Test Feature Flags #28677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
approved these changes
Mar 29, 2024
| export const enableDeferRootSchedulingToMicrotask = false; | ||
|
|
||
| export const enableAsyncActions = true; | ||
|
|
||
| export const alwaysThrottleRetries = true; |
There was a problem hiding this comment.
fwiw, i think if this is true and working we should keep it true to prevent any regressions that would sneak in before we can land the flag in the main fbsource bundle.
There was a problem hiding this comment.
I would feel better about that if I had confidence in the timeline with which we could enable this internally. However, I don't have that, and I would be worried about the possibility that tests are written against the current (non-final) behavior.
There was a problem hiding this comment.
In other words... testing something that we'll never ship (in its current state) is worse to me than testing something that is currently in production (even if it is something we want to move away from eventually).
|
Comparing: 23b32d3...e7db8ea Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
I'm validating this internally with D55534399 before merging. |
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary Makes a few changes to align React Native feature flags for open source and internal test renderer configurations. * Enable `enableSchedulingProfiler` for profiling builds. * Align `ReactFeatureFlags.test-renderer.native.js` (with `ReactFeatureFlags.native-fb.js`). * Enable `enableUseMemoCacheHook`. * Enable `enableFizzExternalRuntime`. * Disable `alwaysThrottleRetries`. ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ```
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
## Summary Makes a few changes to align React Native feature flags for open source and internal test renderer configurations. * Enable `enableSchedulingProfiler` for profiling builds. * Align `ReactFeatureFlags.test-renderer.native.js` (with `ReactFeatureFlags.native-fb.js`). * Enable `enableUseMemoCacheHook`. * Enable `enableFizzExternalRuntime`. * Disable `alwaysThrottleRetries`. ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ``` DiffTrain build for commit 425f72b.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes a few changes to align React Native feature flags for open source and internal test renderer configurations.
enableSchedulingProfilerfor profiling builds.ReactFeatureFlags.test-renderer.native.js(withReactFeatureFlags.native-fb.js).enableUseMemoCacheHook.enableFizzExternalRuntime.alwaysThrottleRetries.How did you test this change?
Ran the following successfully: