Include regular stack trace in serialized errors from Fizz #28684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously only included the component stack. Also cleaned up the fields in Fizz server that wasn't using consistent hidden classes in dev vs prod.
escapeTextForBrowser loops over individual characters on a string and stacks can be quite large to encode.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
servererror
branch
from
a0dc9da to
a5d8b9c
Compare
sebmarkbage
force-pushed
the
servererror
branch
2 times, most recently
from
4255c4e to
cebf8e1
Compare
It can be a bit confusing to see where this error came from otherwise since it didn't come from elsewhere on the client.
sebmarkbage
force-pushed
the
servererror
branch
from
cebf8e1 to
e4d2591
Compare
gnoff
approved these changes
Mar 30, 2024
| @@ -13,7 +13,7 @@ | |||
| // This should be reasonable for all loops in the source. | |||
| // Note that if the numbers are too large, the tests will take too long to fail | |||
| // for this to be useful (each individual test case might hit an infinite loop). | |||
| const MAX_SOURCE_ITERATIONS = 1500; | |||
| const MAX_SOURCE_ITERATIONS = 5000; | |||
There was a problem hiding this comment.
Why did you have to bump this?
There was a problem hiding this comment.
It's in the commit comment but escapeTextForBrowser is a tight loop for escaping and it easily gets up there with escaping stack traces. It's not even deterministic in our tests since it depends on your local file system what stack gets generated and how long it is.
We should probably find a way to disable this for hot loops.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 30, 2024
We previously only included the component stack. Cleaned up the fields in Fizz server that wasn't using consistent hidden classes in dev vs prod. Added a prefix to errors serialized from server rendering. It can be a bit confusing to see where this error came from otherwise since it didn't come from elsewhere on the client. It's really kind of confusing with other recoverable errors that happen on the client too. DiffTrain build for [b9149cc](b9149cc)
sebmarkbage
added a commit
that referenced
this pull request
Apr 4, 2024
Follow up to #28684. V8 includes the message in the stack and printed errors include just the stack property which is assumed to contain the message. Without this, the prefix doesn't get printed in the console. <img width="578" alt="Screenshot 2024-04-03 at 6 32 04 PM" src="https://github.com/facebook/react/assets/63648/d98a2db4-6ebc-4805-b669-59f449dfd21f"> A possible alternative would be to use a nested error with a `cause` like #28736 but that would need some more involved serializing since this prefix is coming from the server. Perhaps as a separate attribute.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
Follow up to #28684. V8 includes the message in the stack and printed errors include just the stack property which is assumed to contain the message. Without this, the prefix doesn't get printed in the console. <img width="578" alt="Screenshot 2024-04-03 at 6 32 04 PM" src="https://github.com/facebook/react/assets/63648/d98a2db4-6ebc-4805-b669-59f449dfd21f"> A possible alternative would be to use a nested error with a `cause` like #28736 but that would need some more involved serializing since this prefix is coming from the server. Perhaps as a separate attribute. DiffTrain build for [583eb67](583eb67)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…28684) We previously only included the component stack. Cleaned up the fields in Fizz server that wasn't using consistent hidden classes in dev vs prod. Added a prefix to errors serialized from server rendering. It can be a bit confusing to see where this error came from otherwise since it didn't come from elsewhere on the client. It's really kind of confusing with other recoverable errors that happen on the client too.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Follow up to facebook#28684. V8 includes the message in the stack and printed errors include just the stack property which is assumed to contain the message. Without this, the prefix doesn't get printed in the console. <img width="578" alt="Screenshot 2024-04-03 at 6 32 04 PM" src="https://github.com/facebook/react/assets/63648/d98a2db4-6ebc-4805-b669-59f449dfd21f"> A possible alternative would be to use a nested error with a `cause` like facebook#28736 but that would need some more involved serializing since this prefix is coming from the server. Perhaps as a separate attribute.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
We previously only included the component stack. Cleaned up the fields in Fizz server that wasn't using consistent hidden classes in dev vs prod. Added a prefix to errors serialized from server rendering. It can be a bit confusing to see where this error came from otherwise since it didn't come from elsewhere on the client. It's really kind of confusing with other recoverable errors that happen on the client too. DiffTrain build for commit b9149cc.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only included the component stack.
Cleaned up the fields in Fizz server that wasn't using consistent hidden classes in dev vs prod.
Added a prefix to errors serialized from server rendering. It can be a bit confusing to see where this error came from otherwise since it didn't come from elsewhere on the client. It's really kind of confusing with other recoverable errors that happen on the client too.