-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert deprecated stalebot to github action #28695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Apr 1, 2024
Comparing: df95577...811512a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
kassens
approved these changes
Apr 1, 2024
Merged
jackpope
added a commit
that referenced
this pull request
Apr 4, 2024
Follows #28695 Now that the action has run successfully in debug mode ([logs](https://github.com/facebook/react/actions/runs/8532177618/job/23372921455#step:2:35)), let's enable it to persist changes. Also changes the number of operations per run from the default of 30 to 100 since we have a large backlog of issues and PRs to work through. Finally adds enhancement label as exempt from stale.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary This repo uses [Stalebot](https://github.com/probot/stale) to manage stale Issues and PRs. Stalebot hasn't been maintained for a couple of years and is officially archived. The number of open Issues and PRs has increased rapidly since early 2022. Some of this looks like issues with Stalebot reliability where labels were not applied or close actions were not taken even when meeting the criteria in the config. In order to make it easier for maintainers to spend time on current Issues and PRs, let's upgrade to the Github Stale Action. For now this PR applies the same config to the new action but we can iterate on it as needed. The goal is to clean up abandoned and no-longer-relevant submissions, not to close Issues that describe active bugs or feedback. ## How did you test this change? Added `debug-only: 'true'` to this PR so we can run the action and review the logs before allowing the action to run on schedule. We may see a large amount of label changes and close actions on the first run as the action clears out previously ignored stale submissions.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Follows facebook#28695 Now that the action has run successfully in debug mode ([logs](https://github.com/facebook/react/actions/runs/8532177618/job/23372921455#step:2:35)), let's enable it to persist changes. Also changes the number of operations per run from the default of 30 to 100 since we have a large backlog of issues and PRs to work through. Finally adds enhancement label as exempt from stale.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This repo uses Stalebot to manage stale Issues and PRs. Stalebot hasn't been maintained for a couple of years and is officially archived. The number of open Issues and PRs has increased rapidly since early 2022. Some of this looks like issues with Stalebot reliability where labels were not applied or close actions were not taken even when meeting the criteria in the config.
In order to make it easier for maintainers to spend time on current Issues and PRs, let's upgrade to the Github Stale Action. For now this PR applies the same config to the new action but we can iterate on it as needed. The goal is to clean up abandoned and no-longer-relevant submissions, not to close Issues that describe active bugs or feedback.
How did you test this change?
Added
debug-only: 'true'
to this PR so we can run the action and review the logs before allowing the action to run on schedule. We may see a large amount of label changes and close actions on the first run as the action clears out previously ignored stale submissions.