Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land disableLegacyMode for OSS #28709

Closed
wants to merge 1 commit into from
Closed

Land disableLegacyMode for OSS #28709

wants to merge 1 commit into from
+3 −7

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 1, 2024

Turns on disableLegacyMode for OSS now that we are building 19 canaries

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 1, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 1, 2024 •
edited
Loading

Comparing: 8833338...91389e1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 175.56 kB = 55.05 kB 54.69 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.94 kB 172.94 kB = 53.91 kB 53.91 kB
facebook-www/ReactDOM-prod.classic.js = 592.68 kB 592.68 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 574.37 kB 574.37 kB = 100.98 kB 100.98 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.profiling.js = 990.08 kB 984.76 kB = 220.57 kB 219.77 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.js = 990.05 kB 984.73 kB = 220.55 kB 219.74 kB
oss-stable/react-dom/cjs/react-dom.production.js = 948.14 kB 942.82 kB = 213.01 kB 212.20 kB
oss-stable-semver/react-dom/cjs/react-dom.production.js = 948.12 kB 942.80 kB = 212.98 kB 212.17 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,403.33 kB 1,392.39 kB = 298.51 kB 296.65 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,403.31 kB 1,392.37 kB = 298.48 kB 296.63 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,338.92 kB 1,328.44 kB = 295.57 kB 293.73 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,338.89 kB 1,328.41 kB = 295.54 kB 293.70 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js = 185.87 kB 184.36 kB = 57.66 kB 57.28 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js = 185.80 kB 184.28 kB = 57.63 kB 57.26 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js = 186.58 kB 185.04 kB = 57.41 kB 57.03 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js = 186.50 kB 184.96 kB = 57.38 kB 57.00 kB
oss-stable/react-dom/umd/react-dom.production.min.js = 176.84 kB 175.32 kB = 55.32 kB 54.96 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js = 176.76 kB 175.25 kB = 55.29 kB 54.93 kB
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 175.56 kB = 55.05 kB 54.69 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js = 177.02 kB 175.49 kB = 55.03 kB 54.66 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 91389e1

@gnoff gnoff force-pushed the land-disableLegacyMode branch from b98cb2b to 3bb5959 Compare April 1, 2024 21:42
@gnoff gnoff force-pushed the land-disableLegacyMode branch from 3bb5959 to 91389e1 Compare April 1, 2024 21:50
@sebmarkbage
Copy link
Collaborator

Should land for www modern mode too.

@sebmarkbage sebmarkbage mentioned this pull request Apr 3, 2024
Merged
sebmarkbage added a commit that referenced this pull request Apr 3, 2024
@sebmarkbage @gnoff
Move ReactDOMLegacy implementation into RootFB (#28656)
8f55a6a 
Only the FB entry point has legacy mode now so we can move the remaining
code in there.

Also enable disableLegacyMode in modern www builds since it doesn't
expose those entry points.

Now dependent on #28709.

---------

Co-authored-by: Josh Story <story@hey.com>
@sebmarkbage
Copy link
Collaborator

I folded this into #28656.

@sebmarkbage sebmarkbage closed this Apr 3, 2024
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
@sebmarkbage
Move ReactDOMLegacy implementation into RootFB (#28656)
2a92b78 
Only the FB entry point has legacy mode now so we can move the remaining
code in there.

Also enable disableLegacyMode in modern www builds since it doesn't
expose those entry points.

Now dependent on #28709.

---------

Co-authored-by: Josh Story <story@hey.com>

DiffTrain build for [8f55a6a](8f55a6a)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @gnoff @AndyPengc12
Move ReactDOMLegacy implementation into RootFB (facebook#28656)
5113f27 
Only the FB entry point has legacy mode now so we can move the remaining
code in there.

Also enable disableLegacyMode in modern www builds since it doesn't
expose those entry points.

Now dependent on facebook#28709.

---------

Co-authored-by: Josh Story <story@hey.com>
@gnoff gnoff deleted the land-disableLegacyMode branch July 25, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnoff @react-sizebot @sebmarkbage @acdlite @facebook-github-bot