Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions of new methods to the react-reconciler readme #28750

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented Apr 4, 2024

Add new reconciler methods since last breaking change to the README based on usage and comments.

@jackpope jackpope requested review from gnoff and acdlite April 4, 2024 21:24
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 4, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 4, 2024

Comparing: fd0da3e...bdea3dc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.88 kB 168.89 kB = 52.68 kB 52.69 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.69 kB 170.69 kB = 53.23 kB 53.24 kB
facebook-www/ReactDOM-prod.classic.js = 591.32 kB 591.32 kB = 103.85 kB 103.85 kB
facebook-www/ReactDOM-prod.modern.js = 567.65 kB 567.65 kB = 99.80 kB 99.80 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against bdea3dc

Copy link
Collaborator

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some more details but looks good

packages/react-reconciler/README.md Outdated Show resolved Hide resolved
packages/react-reconciler/README.md Outdated Show resolved Hide resolved
packages/react-reconciler/README.md Outdated Show resolved Hide resolved
packages/react-reconciler/README.md Outdated Show resolved Hide resolved
packages/react-reconciler/README.md Outdated Show resolved Hide resolved
Co-authored-by: Josh Story <josh.c.story@gmail.com>
@jackpope jackpope merged commit cf5ab8b into facebook:main Apr 25, 2024
38 checks passed
@jackpope jackpope deleted the react-reconciler-readme branch April 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants