Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run stale job hourly #28769

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Run stale job hourly #28769

merged 1 commit into from
Apr 9, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 5, 2024

Run stale job hourly

The stale job is currently limited to 100 API operations per run to protect against API limits and processing of each stale issue / PR take multiple API calls (commenting, adding or removing tags, closing etc).

It seems like we could bump this up as we have more operations available, but the limit seems to be hourly. Instead, this makes the job run hourly, spreading the work.

After an initial wave of marking and closing stale issues, this should keep the labeling "current" according to the "90 day to stale" configuration.

The stale job is currently limited to 100 API operations per run to protect against API limits and processing of each stale issue / PR take multiple API calls (commenting, adding or removing tags, closing etc).

It seems like we could bump this up as we have more operations available, but the limit seems to be hourly. Instead, this makes the job run hourly, spreading the work.

After an initial wave of marking and closing stale issues, this should keep the labeling "current" according to the "90 day to stale" configuration.
@kassens kassens requested a review from jackpope April 5, 2024 20:16
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 5, 2024
@react-sizebot
Copy link

Comparing: 2acfb7b...9f3e070

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.90 kB 168.90 kB = 52.69 kB 52.69 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.71 kB 170.71 kB = 53.24 kB 53.24 kB
facebook-www/ReactDOM-prod.classic.js = 590.23 kB 590.23 kB = 103.62 kB 103.62 kB
facebook-www/ReactDOM-prod.modern.js = 566.56 kB 566.56 kB = 99.57 kB 99.57 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 9f3e070

@kassens kassens merged commit cffbcac into facebook:main Apr 9, 2024
38 checks passed
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants