Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-react-hooks): support ESLint v9 #28772

Closed
wants to merge 2 commits into from
Closed

feat(eslint-plugin-react-hooks): support ESLint v9 #28772

wants to merge 2 commits into from

Conversation

Debbl
Copy link

@Debbl Debbl commented Apr 6, 2024

Summary

Support ESLint v9
https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/

How did you test this change?

  • run yarn test
  • because I can't build this project, I directly changed the node_modules files of eslint-plugin-react-hooks in another project.

@facebook-github-bot
Copy link

Hi @Debbl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-sizebot
Copy link

Comparing: 2acfb7b...b0ce127

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.90 kB 168.90 kB = 52.69 kB 52.69 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.71 kB 170.71 kB = 53.24 kB 53.24 kB
facebook-www/ReactDOM-prod.classic.js = 590.23 kB 590.23 kB = 103.62 kB 103.62 kB
facebook-www/ReactDOM-prod.modern.js = 566.56 kB 566.56 kB = 99.57 kB 99.57 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js +0.49% 27.13 kB 27.27 kB +0.52% 9.34 kB 9.39 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js +0.49% 27.13 kB 27.27 kB +0.52% 9.34 kB 9.39 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js +0.48% 27.73 kB 27.86 kB +0.53% 9.51 kB 9.56 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.36% 92.68 kB 93.02 kB +0.28% 21.79 kB 21.85 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.36% 92.68 kB 93.02 kB +0.28% 21.79 kB 21.85 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.36% 92.83 kB 93.16 kB +0.28% 21.81 kB 21.88 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.35% 93.66 kB 93.99 kB +0.30% 21.99 kB 22.05 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.35% 93.66 kB 93.99 kB +0.30% 21.99 kB 22.05 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.35% 93.81 kB 94.14 kB +0.30% 22.01 kB 22.08 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against b0ce127

@eps1lon
Copy link
Collaborator

eps1lon commented Apr 6, 2024

Just saw this, thank you. I also have #28773 which also sets up testing infra to ensure v9 and earlier work. Will try if your compatibility approach also works since it looks a bit less invasive.

@Debbl
Copy link
Author

Debbl commented Apr 7, 2024

Just saw this, thank you. I also have #28773 which also sets up testing infra to ensure v9 and earlier work. Will try if your compatibility approach also works since it looks a bit less invasive.

I think your PR is better completed.

@Debbl Debbl closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants