Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix diff syncing for Meta #28801

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

josephsavona
Copy link
Contributor

#28796 broke Meta's PR syncing tool, hoping this fixes it

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 9, 2024
@poteto
Copy link
Member

poteto commented Apr 9, 2024

Note that that job only runs on main, so you'll have to land this first to see if it worked. Or you can inspect the circleci bundle (https://app.circleci.com/pipelines/github/facebook/react/52137/workflows/d0b53e30-45aa-4010-a232-4bb4e3392385/jobs/832589/artifacts) and unzip it to see if the directory matches up

@react-sizebot
Copy link

Comparing: 7f5d25e...a7ebf0e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.09 kB 168.09 kB = 52.71 kB 52.71 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 169.90 kB 169.90 kB = 53.25 kB 53.25 kB
facebook-www/ReactDOM-prod.classic.js = 589.45 kB 589.45 kB = 103.79 kB 103.79 kB
facebook-www/ReactDOM-prod.modern.js = 565.29 kB 565.29 kB = 99.92 kB 99.92 kB
test_utils/ReactAllWarnings.js Deleted 64.02 kB 0.00 kB Deleted 15.94 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.02 kB 0.00 kB Deleted 15.94 kB 0.00 kB

Generated by 🚫 dangerJS against a7ebf0e

@josephsavona josephsavona merged commit 64c8d2d into facebook:main Apr 9, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
#28796 broke Meta's PR syncing tool, hoping this fixes it

DiffTrain build for [64c8d2d](64c8d2d)
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
#28796 broke Meta's PR syncing tool, hoping this fixes it
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
#28796 broke Meta's PR syncing tool, hoping this fixes it
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
facebook#28796 broke Meta's PR syncing tool, hoping this fixes it
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
#28796 broke Meta's PR syncing tool, hoping this fixes it

DiffTrain build for commit 64c8d2d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants