Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrevert "Support writing to this.refs from userspace" #28879

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 19, 2024

Reverts #28877

We found the cause of the regression and should be able to land this again.

@kassens kassens requested review from rickhanlonii and acdlite April 19, 2024 18:22
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 19, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 19, 2024

Comparing: 699d03c...e77e16c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 497.71 kB 497.69 kB = 88.93 kB 88.93 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 504.00 kB 503.98 kB = 89.95 kB 89.94 kB
facebook-www/ReactDOM-prod.classic.js = 591.14 kB 591.14 kB = 103.91 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 566.95 kB 566.95 kB = 100.12 kB 100.12 kB
test_utils/ReactAllWarnings.js Deleted 64.80 kB 0.00 kB Deleted 16.14 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/cjs/react.production.js = 18.09 kB 18.06 kB = 4.69 kB 4.68 kB
oss-stable/react/cjs/react.production.js = 16.97 kB 16.93 kB = 4.43 kB 4.42 kB
oss-stable-semver/react/cjs/react.production.js = 16.95 kB 16.91 kB = 4.41 kB 4.39 kB
test_utils/ReactAllWarnings.js Deleted 64.80 kB 0.00 kB Deleted 16.14 kB 0.00 kB

Generated by 🚫 dangerJS against e77e16c

@kassens kassens force-pushed the revert-28877-revert-28867-make-inst-refs-writable branch from ec073b5 to 4d944b6 Compare April 23, 2024 16:37
@kassens kassens requested a review from acdlite April 23, 2024 16:38
@kassens
Copy link
Member Author

kassens commented Apr 23, 2024

@acdlite I keep the this.refs = {} "unfreezing" the object in mountClassInstance for copied class implementations such as create-create-class, see 4d944b6.
Is there a downside beyond the useless new empty object?

@kassens kassens merged commit b039be6 into main Apr 24, 2024
38 checks passed
@kassens kassens deleted the revert-28877-revert-28867-make-inst-refs-writable branch April 24, 2024 14:03
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
Reverts #28877

We found the cause of the regression and should be able to land this
again.

DiffTrain build for commit b039be6.
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
Reverts #28877

We found the cause of the regression and should be able to land this
again.

DiffTrain build for [b039be6](b039be6)
bigfootjon pushed a commit that referenced this pull request Apr 25, 2024
Reverts #28877

We found the cause of the regression and should be able to land this
again.

DiffTrain build for commit b039be6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants