Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Land #28798) Move Current Owner (and Cache) to an Async Dispatcher #28912

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 25, 2024

Rebasing and landing #28798

This PR was approved already but held back to give time for the sync. Rebased and landing here without pushing to seb's remote to avoid possibility of lost updates

Basically always but we currently don't actually need it for prod on the
client.
This means that usage internal to the reconciler can refer to it directly
without going through the dispatcher.
This will later use AsyncLocalStorage to track this just like the cache.
We need to be careful about only getting it in branches that has the dispatcher
activated and if the dispatcher is activate.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 25, 2024
@react-sizebot
Copy link

Comparing: f8a8eac...7671621

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.09 kB 591.11 kB = 103.93 kB 103.94 kB
facebook-www/ReactDOM-prod.modern.js = 567.32 kB 567.33 kB +0.01% 100.33 kB 100.34 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js +4.30% 2.86 kB 2.98 kB +3.43% 1.23 kB 1.27 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +4.30% 2.86 kB 2.98 kB +3.43% 1.23 kB 1.27 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js +4.18% 1.17 kB 1.22 kB +2.58% 0.58 kB 0.60 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js +4.18% 1.17 kB 1.22 kB +2.58% 0.58 kB 0.60 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js +4.18% 1.17 kB 1.22 kB +2.58% 0.58 kB 0.60 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react/cjs/JSXRuntime-prod.js +4.30% 2.86 kB 2.98 kB +3.43% 1.23 kB 1.27 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +4.30% 2.86 kB 2.98 kB +3.43% 1.23 kB 1.27 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js +4.18% 1.17 kB 1.22 kB +2.58% 0.58 kB 0.60 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js +4.18% 1.17 kB 1.22 kB +2.58% 0.58 kB 0.60 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js +4.18% 1.17 kB 1.22 kB +2.58% 0.58 kB 0.60 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js +0.31% 41.28 kB 41.41 kB +0.35% 12.47 kB 12.52 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js +0.31% 41.28 kB 41.41 kB +0.35% 12.47 kB 12.52 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js +0.31% 41.28 kB 41.41 kB +0.35% 12.47 kB 12.52 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js +0.30% 42.51 kB 42.64 kB +0.33% 12.82 kB 12.86 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js +0.30% 42.51 kB 42.64 kB +0.33% 12.82 kB 12.86 kB
oss-stable/react/cjs/react-jsx-runtime.development.js +0.30% 42.51 kB 42.64 kB +0.33% 12.82 kB 12.86 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js +0.25% 42.94 kB 43.05 kB +0.32% 12.94 kB 12.99 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js +0.25% 42.94 kB 43.05 kB +0.32% 12.94 kB 12.99 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js +0.25% 42.94 kB 43.05 kB +0.32% 12.94 kB 12.99 kB
oss-experimental/react/cjs/react.react-server.production.js = 18.70 kB 18.62 kB = 4.97 kB 4.96 kB
oss-experimental/react/cjs/react.production.js = 18.09 kB 18.01 kB = 4.69 kB 4.68 kB
oss-stable/react/cjs/react.production.js = 16.97 kB 16.89 kB = 4.43 kB 4.42 kB
oss-stable-semver/react/cjs/react.production.js = 16.95 kB 16.87 kB = 4.41 kB 4.39 kB
oss-stable/react/cjs/react.react-server.production.js = 15.07 kB 14.99 kB = 4.11 kB 4.10 kB
oss-stable-semver/react/cjs/react.react-server.production.js = 15.04 kB 14.96 kB = 4.08 kB 4.07 kB
facebook-www/React-profiling.classic.js = 23.29 kB 23.12 kB = 5.93 kB 5.92 kB
facebook-www/React-profiling.modern.js = 23.29 kB 23.12 kB = 5.93 kB 5.92 kB
facebook-www/React-prod.classic.js = 22.86 kB 22.68 kB = 5.85 kB 5.84 kB
facebook-www/React-prod.modern.js = 22.86 kB 22.68 kB = 5.85 kB 5.84 kB
oss-experimental/react/cjs/react-jsx-runtime.production.js = 0.99 kB 0.98 kB = 0.51 kB 0.50 kB
oss-stable-semver/react/cjs/react-jsx-runtime.production.js = 0.99 kB 0.98 kB = 0.51 kB 0.50 kB
oss-stable/react/cjs/react-jsx-runtime.production.js = 0.99 kB 0.98 kB = 0.51 kB 0.50 kB
oss-experimental/react/cjs/react-jsx-runtime.profiling.js = 0.99 kB 0.98 kB = 0.51 kB 0.50 kB
oss-stable-semver/react/cjs/react-jsx-runtime.profiling.js = 0.99 kB 0.98 kB = 0.51 kB 0.50 kB
oss-stable/react/cjs/react-jsx-runtime.profiling.js = 0.99 kB 0.98 kB = 0.51 kB 0.50 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 7671621

@gnoff gnoff merged commit 94eed63 into facebook:main Apr 25, 2024
38 checks passed
@gnoff gnoff deleted the asynccurrentowner branch April 25, 2024 17:40
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
…28912)

Rebasing and landing #28798

This PR was approved already but held back to give time for the sync.
Rebased and landing here without pushing to seb's remote to avoid
possibility of lost updates

---------

Co-authored-by: Sebastian Markbage <sebastian@calyptus.eu>

DiffTrain build for commit 94eed63.
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
…28912)

Rebasing and landing #28798

This PR was approved already but held back to give time for the sync.
Rebased and landing here without pushing to seb's remote to avoid
possibility of lost updates

---------

Co-authored-by: Sebastian Markbage <sebastian@calyptus.eu>

DiffTrain build for [94eed63](94eed63)
bigfootjon pushed a commit that referenced this pull request Apr 25, 2024
…28912)

Rebasing and landing #28798

This PR was approved already but held back to give time for the sync.
Rebased and landing here without pushing to seb's remote to avoid
possibility of lost updates

---------

Co-authored-by: Sebastian Markbage <sebastian@calyptus.eu>

DiffTrain build for commit 94eed63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants