Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hyperlink): added a hyperlink to Node in README.md file #28940

Merged
merged 1 commit into from
May 19, 2024
Merged

feat(hyperlink): added a hyperlink to Node in README.md file #28940

merged 1 commit into from
May 19, 2024

Conversation

itzzjb
Copy link
Contributor

@itzzjb itzzjb commented Apr 27, 2024

As a fellow beginner to React, I didn't even know React runs on top of Node when I started.

So, some beginners might get confused about what is Node and how to find details about it or how to download it.

So, I thought to add a hyperlink to Node replacing the word Node in the README.md file. I think this might be a valuable contribution.

  • Januda

@facebook-github-bot
Copy link

Hi @itzzjb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@itzzjb itzzjb changed the title Added a hyperlink to Node Adding a hyperlink to Node in README.md file Apr 27, 2024
@react-sizebot
Copy link

Comparing: 4ddff73...384eb6c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.11 kB 591.11 kB = 103.94 kB 103.94 kB
facebook-www/ReactDOM-prod.modern.js = 567.33 kB 567.33 kB = 100.34 kB 100.34 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 384eb6c

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@itzzjb itzzjb changed the title Adding a hyperlink to Node in README.md file feat(hyperlink): Adding a hyperlink to Node in README.md file Apr 28, 2024
@itzzjb itzzjb changed the title feat(hyperlink): Adding a hyperlink to Node in README.md file feat(hyperlink): added a hyperlink to Node in README.md file Apr 28, 2024
@rickhanlonii rickhanlonii merged commit f74c5cc into facebook:main May 19, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants