[react-native] Add unit test to ReactNativeAttributePayload #28955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
approved these changes
Apr 30, 2024
| const validAttributes = {foo: true, style: {foo: true}}; | ||
| expect(diff({}, {foo: 4, style: {foo: 2}}, validAttributes)).toEqual({ | ||
| foo: 2, | ||
| }); |
There was a problem hiding this comment.
Yuup.. which means code like https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Components/View/View.js#L103 is unnecessary
For most native props on View etc, we allow them as valid attributes as a direct prop and as style..
There was a problem hiding this comment.
Oh wait is this only for style properties, I remember that now.
But what happens if you have custom native component that defines a backgroundColor prop?
|
Comparing: 190cc99...2573291 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm looking at cleaning up some unnecessary manual property flattening in React Native and wanted to verify this behaviour is working as expected, where properties from nested objects will always overwrite properties from the base object.
How did you test this change?
Unit tests