-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize key in Developer Tools display #28991
Conversation
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Not sure devtools should just modify and display something different. That seems like it could easily be confusing - especially when that small difference is the cause of some sort of bug and need debugging. Not sure if this is a common issue as I don't work on devtools, maybe it could display invisible characters such as newline escape codes like JSON, i.e. |
Yup, I think we don't need to replace anything here and instead use I could help with building the extension locally, if needed. |
Yeah sure, I could do that. But I would need your help building the extension locally to test it out @hoxyq |
@tarunkishore2303 Are you still working on this? If not, can someone else pick this up? |
Yea sure we could try that |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Added an utility function to sanitize the string before displaying it in tree
Finishes #28984
How did you test this change?
Added test cases for the utility function that has been created.