Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2 no longer existing files from inlinedHostConfig #29027

Merged
merged 1 commit into from
May 14, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented May 8, 2024

Remove 2 no longer existing files from inlinedHostConfig

While looking for .classic forks, I noticed these files no longer exist.

While looking for `.classic` forks, I noticed these files no longer exist.
@kassens kassens requested a review from rickhanlonii May 8, 2024 17:53
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label May 8, 2024
@react-sizebot
Copy link

Comparing: b1d4096...33685d5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 494.06 kB 494.06 kB = 88.22 kB 88.22 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.93 kB 88.93 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 33685d5

@kassens kassens merged commit 26f2496 into facebook:main May 14, 2024
38 checks passed
@kassens kassens deleted the pr29027 branch May 14, 2024 14:07
Anonymous-Bot-Fucker added a commit to Anonymous-Bot-Fucker/react that referenced this pull request May 14, 2024
) (#1)

Remove 2 no longer existing files from inlinedHostConfig

While looking for `.classic` forks, I noticed these files no longer
exist.

Co-authored-by: Jan Kassens <jkassens@meta.com>
Anonymous-Bot-Fucker added a commit to Anonymous-Bot-Fucker/react that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants