Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable disableStringRefs and enableRefAsProp for React Native (Meta) #29177

Merged
merged 1 commit into from
May 21, 2024

Conversation

yungsters
Copy link
Contributor

@yungsters yungsters commented May 20, 2024

Summary

Enables the disableStringRefs and enableRefAsProp feature flags for React Native (Meta).

How did you test this change?

$ yarn test
$ yarn flow fabric

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 10:26pm

@react-sizebot
Copy link

Comparing: bf046e8...b9a1f72

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.71 kB 495.71 kB = 88.78 kB 88.78 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.51 kB 500.51 kB = 89.47 kB 89.47 kB
facebook-www/ReactDOM-prod.classic.js = 592.86 kB 592.86 kB = 104.28 kB 104.28 kB
facebook-www/ReactDOM-prod.modern.js = 569.08 kB 569.08 kB = 100.69 kB 100.69 kB
facebook-react-native/react/cjs/React-dev.js = 114.73 kB 104.33 kB = 30.03 kB 27.97 kB
facebook-react-native/react/cjs/React-profiling.js = 23.64 kB 20.08 kB = 6.04 kB 5.18 kB
facebook-react-native/react/cjs/React-prod.js = 23.20 kB 19.65 kB = 5.97 kB 5.10 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 52.81 kB 43.47 kB = 15.06 kB 13.13 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 51.57 kB 42.23 kB = 14.71 kB 12.77 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js = 4.19 kB 1.73 kB = 1.50 kB 0.75 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js = 4.19 kB 1.73 kB = 1.50 kB 0.75 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactNativeRenderer-dev.fb.js = 963.71 kB 961.70 kB = 209.28 kB 208.73 kB
react-native/implementations/ReactFabric-dev.fb.js = 952.44 kB 950.44 kB = 205.93 kB 205.35 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 398.85 kB 397.75 kB = 69.40 kB 69.18 kB
react-native/implementations/ReactFabric-profiling.fb.js = 392.93 kB 391.84 kB = 68.29 kB 68.06 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 371.61 kB 370.51 kB = 65.12 kB 64.90 kB
react-native/implementations/ReactFabric-prod.fb.js = 365.64 kB 364.54 kB = 64.08 kB 63.84 kB
facebook-react-native/react/cjs/React-dev.js = 114.73 kB 104.33 kB = 30.03 kB 27.97 kB
facebook-react-native/react/cjs/React-profiling.js = 23.64 kB 20.08 kB = 6.04 kB 5.18 kB
facebook-react-native/react/cjs/React-prod.js = 23.20 kB 19.65 kB = 5.97 kB 5.10 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 52.81 kB 43.47 kB = 15.06 kB 13.13 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 51.57 kB 42.23 kB = 14.71 kB 12.77 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js = 4.19 kB 1.73 kB = 1.50 kB 0.75 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js = 4.19 kB 1.73 kB = 1.50 kB 0.75 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Generated by 🚫 dangerJS against b9a1f72

@yungsters yungsters requested review from kassens and rickhanlonii May 21, 2024 08:14
@yungsters yungsters merged commit 7621466 into facebook:main May 21, 2024
40 checks passed
@yungsters yungsters deleted the rn-flags branch May 21, 2024 10:19
github-actions bot pushed a commit that referenced this pull request May 21, 2024
…ta) (#29177)

## Summary

Enables the `disableStringRefs` and `enableRefAsProp` feature flags for
React Native (Meta).

## How did you test this change?

```
$ yarn test
$ yarn flow fabric
```

DiffTrain build for commit 7621466.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants