Batch updates in initial render #2935
Merged
+46
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean we can re-enable the callback to |
|
No I think that is still broken but this makes it easier. |
Currently, the first setState that happens during initial render will start a new batch. Any subsequent updates will be batched. That means that the first setState is synchronous but any subsequent setStates are asynchronous. This commit makes it so that the batching starts at the root. That way all the setStates that happen within life-cycle methods are asynchronous.
sebmarkbage
force-pushed
the
batchupdates
branch
from
7764e99 to
9811b10
Compare
sebmarkbage
added a commit
that referenced
this pull request
Jan 27, 2015
Batch updates in initial render
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Apr 30, 2015
Analogous change to facebook#2935.
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Apr 30, 2015
Analogous change to facebook#2935.
framp
pushed a commit
to framp/react
that referenced
this pull request
May 26, 2015
Analogous change to facebook#2935.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the first setState that happens during initial render will
start a new batch. Any subsequent updates will be batched. That means that
the first setState is synchronous but any subsequent setStates are
asynchronous.
This commit makes it so that the batching starts at the root. That way all
the setStates that happen within life-cycle methods are asynchronous.