Export version from react-dom entry with react-server condition
#29596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: ea6e059...f69982c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Especially important since the workaround in Next.js will hide version mismatches. |
acdlite
approved these changes
May 28, 2024
nikeee
pushed a commit
to nikeee/react
that referenced
this pull request
May 28, 2024
unstubbable
added a commit
to unstubbable/next.js
that referenced
this pull request
Jun 6, 2024
The workaround is not needed anymore because of facebook/react#29596.
eps1lon
pushed a commit
to vercel/next.js
that referenced
this pull request
Jun 10, 2024
The workaround is not needed anymore because of facebook/react#29596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By exporting the
versionfor this entry we can avoid this workaround in Next.js: https://github.com/vercel/next.js/blob/0f55f2ab1da5ee98b39316b4790734dd92ccc5bc/packages/next/src/server/future/route-modules/app-page/vendored/rsc/entrypoints.ts#L73-L79How did you test this change?
I ran
RELEASE_CHANNEL=stable node scripts/rollup/build.js --type=NODE_DEVand then inspected the contents ofbuild/node_modules/react-dom/cjs/react-dom.react-server.development.jsto verify thatversionis included in theexports.