Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repro function expr hoisting #29615

Merged
merged 2 commits into from
May 28, 2024
Merged

Repro function expr hoisting #29615

merged 2 commits into from
May 28, 2024

Conversation

josephsavona
Copy link
Contributor

Modified version of @mofeiZ's #29232 with CI passing (had to run prettier)

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:18pm

@josephsavona
Copy link
Contributor Author

closes #29232

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label May 28, 2024
@react-sizebot
Copy link

react-sizebot commented May 28, 2024 •
edited
Loading

Comparing: 4c2e457...23da504

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.89 kB 495.89 kB = 88.83 kB 88.83 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.69 kB 500.69 kB = 89.51 kB 89.51 kB
facebook-www/ReactDOM-prod.classic.js = 593.05 kB 593.05 kB = 104.32 kB 104.32 kB
facebook-www/ReactDOM-prod.modern.js = 569.27 kB 569.27 kB = 100.72 kB 100.72 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Generated by 🚫 dangerJS against 23da504

@josephsavona josephsavona force-pushed the repro-function-expr-hoisting branch from b116dac to 23da504 Compare May 28, 2024 16:13
@josephsavona josephsavona merged commit 4ec6a6f into main May 28, 2024
50 checks passed
@josephsavona josephsavona mentioned this pull request May 28, 2024
Closed
nikeee pushed a commit to nikeee/react that referenced this pull request May 28, 2024
@josephsavona @mofeiZ @nikeee
Repro function expr hoisting (facebook#29615)
057666b 
Modified version of @mofeiZ's facebook#29232 with CI passing (had to run
prettier)

---------

Co-authored-by: Mofei Zhang <feifei0@meta.com>
@eps1lon eps1lon mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Component: Optimizing Compiler React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephsavona @react-sizebot @facebook-github-bot @mofeiZ