Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Compiler Logical Negation Constant Propagation #29623

Merged
merged 1 commit into from
May 29, 2024

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented May 28, 2024

Summary

Resolves #29622

How did you test this change?

I verified the implementation using the test.

Note:
This PR was done without waiting for approval in #29622, so feel free to just close it.

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 0:23am

@react-sizebot
Copy link

react-sizebot commented May 28, 2024

Comparing: 97722ca...93c4b02

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.38 kB 496.38 kB = 88.84 kB 88.84 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 501.20 kB 501.20 kB = 89.53 kB 89.53 kB
facebook-www/ReactDOM-prod.classic.js = 593.81 kB 593.81 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 570.20 kB 570.20 kB = 100.85 kB 100.85 kB
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Generated by 🚫 dangerJS against 93c4b02

@nikeee nikeee marked this pull request as ready for review May 28, 2024 21:47
@nikeee nikeee force-pushed the boolean-negation branch 2 times, most recently from 57bc4a1 to c6a277f Compare May 28, 2024 22:40
@josephsavona
Copy link
Contributor

Looks like you have to run prettier: yarn workspace babel-plugin-react-compiler prettier from the compiler directory

@nikeee nikeee force-pushed the boolean-negation branch from c6a277f to 93c4b02 Compare May 29, 2024 00:18
@nikeee
Copy link
Contributor Author

nikeee commented May 29, 2024

My bad! Updated in 93c4b02

@josephsavona josephsavona merged commit 320da67 into facebook:main May 29, 2024
50 checks passed
@nikeee nikeee deleted the boolean-negation branch May 29, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler Logical Negation Constant Propagation
4 participants