Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xplat test variants #29734

Merged
merged 17 commits into from
Jun 4, 2024
Merged

Add xplat test variants #29734

merged 17 commits into from
Jun 4, 2024

Conversation

rickhanlonii
Copy link
Member

Overview

We didn't have any tests that ran in persistent mode with the xplat feature flags (for either variant).

As a result, invalid test gating like in #29664 were not caught.

This PR adds test flavors for ReactFeatureFlag-native-fb.js in both variants.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 3, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 4:38pm

@react-sizebot
Copy link

react-sizebot commented Jun 3, 2024 •
edited
Loading

Comparing: b421783...22067cd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.48 kB 496.48 kB = 88.87 kB 88.87 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 501.30 kB 501.30 kB = 89.56 kB 89.56 kB
facebook-www/ReactDOM-prod.classic.js = 593.97 kB 593.97 kB = 104.49 kB 104.48 kB
facebook-www/ReactDOM-prod.modern.js = 570.35 kB 570.35 kB = 100.89 kB 100.89 kB
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Generated by 🚫 dangerJS against 22067cd

@yungsters
Copy link
Contributor

yungsters commented Jun 3, 2024 •
edited
Loading

Should we name this either “fbsource” (to match the build branch name and repository name) or “native” (to match the flavor being tested) instead of introducing a new name / concept? (I think this would be the first time “xplat” is used in this repo.)

@rickhanlonii rickhanlonii mentioned this pull request Jun 3, 2024
Merged
@rickhanlonii rickhanlonii reopened this Jun 4, 2024
rickhanlonii
rickhanlonii commented Jun 4, 2024
View reviewed changes
packages/react-native-renderer/src/__tests__/ResponderEventPlugin-test.internal.js
}
},
// TODO: this is a long running test, we should speed it up.
60 * 1000,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only line changed in this test

yungsters
yungsters approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@yungsters yungsters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@rickhanlonii rickhanlonii merged commit eabb681 into facebook:main Jun 4, 2024
44 checks passed
@rickhanlonii rickhanlonii deleted the rh/xplat-tests branch June 4, 2024 17:07
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
@rickhanlonii
Add xplat test variants (#29734)
170f76d 
## Overview

We didn't have any tests that ran in persistent mode with the xplat
feature flags (for either variant).

As a result, invalid test gating like in
#29664 were not caught.

This PR adds test flavors for `ReactFeatureFlag-native-fb.js` in both
variants.

DiffTrain build for commit eabb681.
@eps1lon eps1lon mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungsters yungsters yungsters approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @yungsters @facebook-github-bot