Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Fix outdated comment in scripts/release #29800

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[compiler] Fix outdated comment in scripts/release #29800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions compiler/scripts/release/publish-manual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,18 @@ async function getDateStringForCommit(commit) {
}

/**
* Please login to npm first with `npm login`. You will also need 2FA enabled to push to npm.
*
* Script for publishing PUBLISHABLE_PACKAGES to npm. By default, this runs in tarball mode, meaning
* the script will only print out what the contents of the files included in the npm tarball would
* be.
*
* Please run this first (ie `yarn npm:publish`) and double check the contents of the files that
* will be pushed to npm.
*
* If it looks good, you can run `yarn npm:publish --for-real` to really publish to npm. There's a
* small annoying delay before the packages are actually pushed to give you time to panic cancel. In
* this mode, we will bump the version field of each package's package.json, and git commit it.
* Then, the packages will be published to npm.
* If it looks good, you can run `yarn npm:publish --for-real` to really publish to npm. You must
* have 2FA enabled first and the script will prompt you to enter a 2FA code before proceeding.
* There's a small annoying delay before the packages are actually pushed to give you time to panic
* cancel. In this mode, we will bump the version field of each package's package.json, and git
* commit it. Then, the packages will be published to npm.
*
* Optionally, you can add the `--debug` flag to `yarn npm:publish --debug --for-real` to run all
* steps, but the final npm publish step will have the `--dry-run` flag added to it. This will make
Expand Down