Updates ViewConfig types to delegate isInAParentText context

[rozele]

Summary

Now that HostContext determination for Fabric is a DEV-only behavior, we can move the HostContext determination to resolve from the ViewConfig for a given type. Doing this will allow arbitrary types to register themselves as potential parents of raw text string children. This is the first of two diffs for react as we'll:

1. Add the new property to the ViewConfig types
2. Update React Native to include the supportsRawText property for RCTText, RCTVirtualText, AndroidTextInput, etc.
3. Switch the behavior of react to read from the ViewConfig rather than a static list of types.

How did you test this change?

• yarn test
• yarn test --prod
• Pulled change into react-native, added supportsRawText props to RCTText, RCTVirtualText, etc. ViewConfigs and confirmed everything type checks.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 14, 2024 5:47pm

[react-sizebot]

Comparing: 3154ec8...224892e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.66 kB	6.66 kB	=	1.82 kB	1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.93 kB	497.93 kB	=	89.26 kB	89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.67 kB	6.67 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.75 kB	502.75 kB	=	89.96 kB	89.96 kB
facebook-www/ReactDOM-prod.classic.js	=	583.08 kB	583.08 kB	=	103.21 kB	103.21 kB
facebook-www/ReactDOM-prod.modern.js	=	571.52 kB	571.52 kB	=	101.27 kB	101.27 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
react-native/shims/ReactNativeTypes.js	+0.67%	8.67 kB	8.73 kB	+0.52%	2.32 kB	2.33 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Generated by 🚫 dangerJS against 224892e

[javache]

Could we make this change incremental? Eg check for supportsRawText, and if not set or false, check the existing list of component names? That way we have to do less juggling to make this change atomic.

[rickhanlonii]

Can you add tests? I know that this just updates the types, but there should be some sort of tests for this behavior before we start implementing it. And the existing tests that are there are currently passing, but should fail without the changes @javache mentioned.

Here's where I would add them:

react/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js

Line 583 in 1940cb2

it('should console error for text not inside of a <Text> ancestor', async () => {

Need to add tests

[rozele]

Could we make this change incremental? Eg check for supportsRawText, and if not set or false, check the existing list of component names? That way we have to do less juggling to make this change atomic.

@javache Not seeing the value in this, it's just as easy to:

1. expose the types in React
2. make the change in RN to use the types
3. Switch to using ViewConfig in React

As it is to:

1. Expose the types and using ViewConfig with fallback in React
2. Make the change in RN to use the types
3. Remove the fallback list in React

[rozele]

@rickhanlonii if we are just adding types in this change, there's not really anything to test. The subsequent change after RN is updated to consume the new types will need to update the existing tests, which appear to have sufficient coverage.

[rickhanlonii]

here's not really anything to test

Yeah ok sure, we can add tests when we do step 3 to actually consume the prop in React. If you're going this route though, it would be easier to just add the props to the config with a FlowFixMe and remove the FlowFixMe after the behavior change lands.

Then you could add the type, the behavior, and the tests all in one React PR.