Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[react-devtools] divided inspecting elements between inspecting do… #29885

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix[react-devtools] divided inspecting elements between inspecting do… #29885

merged 1 commit into from
Jun 13, 2024

Conversation

vzaidman
Copy link
Contributor

before

  • nav to dom element from devtools
  • nav to devtools element from page
    are enabled on extension and disabled on the rest of the flavors.

extension:

  • nav to dom element from devtools enabled and working
  • nav to devtools element from page enabled and working
    Screenshot 2024-06-13 at 11 15 11

inline:

  • nav to dom element from devtools disabled
  • nav to devtools element from page disabled
    before-inline

standalone:

  • nav to dom element from devtools disabled
  • nav to devtools element from page disabled
    before-standalone

fusebox:

  • nav to dom element from devtools disabled
  • nav to devtools element from page disabled
    before-fusebox

after

same:

  • nav to dom element from devtools
  • nav to devtools element from page
    are enabled on extension and disabled on inline.

change:
standalone and fusebox can nav to devtools element from page

extension:

  • nav to dom element from devtools enabled and working
  • nav to devtools element from page enabled and working
    Screenshot 2024-06-13 at 10 50 25

inline:

  • nav to dom element from devtools disabled
  • nav to devtools element from page disabled
    after-inline

standalone:

  • nav to dom element from devtools disabled
  • nav to devtools element from page enabled and working
    after-standalone

fusebox:

  • nav to dom element from devtools disabled
  • nav to devtools element from page enabled and working
    after-fusebox

@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 2:26pm

@vzaidman vzaidman force-pushed the support-nav-to-element-on-page-click branch from 462cd8a to 5ae597e Compare June 13, 2024 10:29
hoxyq
hoxyq reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think inline version supported the click-to-inspect button, can you double check this? Prior to changes in #29779.

nit: I would rename these to supportsClickToInspect and supportsInspectingMatchingDOMElement

@hoxyq
Copy link
Contributor

hoxyq commented Jun 13, 2024

I think inline version supported the click-to-inspect button, can you double check this? Prior to changes in #29779.

nit: I would rename these to supportsClickToInspect and supportsInspectingMatchingDOMElement

By the way, if we had it in inline version, and it didn't work correctly, then lets remove it

@vzaidman
Copy link
Contributor Author

vzaidman commented Jun 13, 2024 •
edited
Loading

By the way, if we had it in inline version, and it didn't work correctly, then lets remove it

@hoxyq Just checked- it doesn't work in inline mode so we better keep it disabled.

@vzaidman
fix[react-devtools] divided inspecting elements between inspecting do…
c34a172 
…m elements from matching dev tools elements and nav to dev tool elements on page click
@vzaidman vzaidman force-pushed the support-nav-to-element-on-page-click branch from 5ae597e to c34a172 Compare June 13, 2024 14:24
@vzaidman vzaidman requested a review from hoxyq June 13, 2024 14:24
@vzaidman
Copy link
Contributor Author

vzaidman commented Jun 13, 2024 •
edited
Loading

nit: I would rename these to supportsClickToInspect and supportsInspectingMatchingDOMElement

@hoxyq fixed

@vzaidman vzaidman merged commit d9a5b63 into main Jun 13, 2024
44 checks passed
@vzaidman vzaidman mentioned this pull request Jun 13, 2024
Merged
@hoxyq hoxyq deleted the support-nav-to-element-on-page-click branch June 13, 2024 15:01
@eps1lon eps1lon mentioned this pull request Jun 13, 2024
Merged
@hoxyq hoxyq mentioned this pull request Jun 17, 2024
Merged
hoxyq added a commit that referenced this pull request Jun 18, 2024
@hoxyq
React DevTools 5.2.0 -> 5.3.0 (#29918)
1434af3 
Full list of changes:

* chore[react-devtools]: improve console arguments formatting before
passing it to original console ([hoxyq](https://github.com/hoxyq) in
[#29873](#29873))
* chore[react-devtools]: unify console patching and default to ansi
escape symbols ([hoxyq](https://github.com/hoxyq) in
[#29869](#29869))
* chore[react-devtools/backend]: remove
consoleManagedByDevToolsDuringStrictMode
([hoxyq](https://github.com/hoxyq) in
[#29856](#29856))
* chore[react-devtools/extensions]: make source maps url relative
([hoxyq](https://github.com/hoxyq) in
[#29886](#29886))
* fix[react-devtools] divided inspecting elements between inspecting do…
([vzaidman](https://github.com/vzaidman) in
[#29885](#29885))
* [Fiber] Create virtual Fiber when an error occurs during reconcilation
([sebmarkbage](https://github.com/sebmarkbage) in
[#29804](#29804))
* fix[react-devtools] component badge in light mode is now not invisible
([vzaidman](https://github.com/vzaidman) in
[#29852](#29852))
* Remove Warning: prefix and toString on console Arguments
([sebmarkbage](https://github.com/sebmarkbage) in
[#29839](#29839))
* Add jest lint rules ([rickhanlonii](https://github.com/rickhanlonii)
in [#29760](#29760))
* [Fiber] Track the Real Fiber for Key Warnings
([sebmarkbage](https://github.com/sebmarkbage) in
[#29791](#29791))
* fix[react-devtools/store-test]: fork the test to represent current be…
([hoxyq](https://github.com/hoxyq) in
[#29777](#29777))
* Default native inspections config false
([vzaidman](https://github.com/vzaidman) in
[#29784](#29784))
* fix[react-devtools] remove native inspection button when it can't be
used ([vzaidman](https://github.com/vzaidman) in
[#29779](#29779))
* chore[react-devtools]: ip => internal-ip
([hoxyq](https://github.com/hoxyq) in
[#29772](#29772))
* Fix #29724: `ip` dependency update for CVE-2024-29415
([Rekl0w](https://github.com/Rekl0w) in
[#29725](#29725))
* cleanup[react-devtools]: remove unused supportsProfiling flag from
store config ([hoxyq](https://github.com/hoxyq) in
[#29193](#29193))
* [Fiber] Enable Native console.createTask Stacks When Available
([sebmarkbage](https://github.com/sebmarkbage) in
[#29223](#29223))
* Move createElement/JSX Warnings into the Renderer
([sebmarkbage](https://github.com/sebmarkbage) in
[#29088](#29088))
* Set the current fiber to the source of the error during error
reporting ([sebmarkbage](https://github.com/sebmarkbage) in
[#29044](#29044))
* Unify ReactFiberCurrentOwner and ReactCurrentFiber
([sebmarkbage](https://github.com/sebmarkbage) in
[#29038](#29038))
* Dim `console` calls on additional Effect invocations due to
`StrictMode` ([eps1lon](https://github.com/eps1lon) in
[#29007](#29007))
* refactor[react-devtools]: rewrite context menus
([hoxyq](https://github.com/hoxyq) in
[#29049](#29049))
@eps1lon eps1lon mentioned this pull request Jul 10, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq hoxyq approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vzaidman @hoxyq @facebook-github-bot