[compiler] health-check : improve check logic for next.js' stirctMode

[coleea]

Summary

How did you test this change?

1. I published changed code to https://www.npmjs.com/package/react-compiler-test

2. I created two next.js project. the one is app route-based and another one is page route-based

3. I tested every possible scenario (by running npx react-compiler-test.

3-1) App router + reactStrictMode: true => strict mode.
3-2) App router + reactStrictMode: false => non-strict mode.
3-3) App router + reactStrictMode option is not set => strict mode.
3-4) Page router + reactStrictMode: true => strict mode.
3-5) Page router + reactStrictMode: false => non-strict mode.
3-6) Page router + reactStrictMode option is not set => non-strict mode.

Test passed every case. the previous PR #29167 not covered the 3rd case.

Plus, I added some minor changes. the previous PR can cover reactStrictMode: true but does not cover reactStrictMode : true or reactStrictMode : true . I modified code to detect whitespace between reactStrictMode and :.

In addition, if <StrictMode> component is in comment (eg : // <StrictMode></StrictMode> ) , prevent recognizing it as a valid component.

In fact, multi-line comment also should be detected. However, it is difficult to detect this by regular expressions alone.
multi-line comment has three possible case
1)

/* 
    <StrictMode>
    <StrictMode/> 
*/

/* */
<StrictMode><StrictMode/> 

<StrictMode><StrictMode/> 
/* */

More sophisticated methods are needed to separate the three cases (eg : esprima). However, they were excluded from this PR.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 7:55am

[facebook-github-bot]

Hi @coleea!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[react-sizebot]

Comparing: f5d2feb...f9baf6f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.93 kB	497.93 kB	=	89.26 kB	89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.75 kB	502.75 kB	=	89.96 kB	89.96 kB
facebook-www/ReactDOM-prod.classic.js	=	597.10 kB	597.10 kB	=	105.31 kB	105.31 kB
facebook-www/ReactDOM-prod.modern.js	=	571.44 kB	571.44 kB	=	101.24 kB	101.24 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Generated by 🚫 dangerJS against f9baf6f

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[ojj1123]

I don't think what this healthcheck checks next config, is a good workaround.

The react frameworks are made continuously. Whenever the new frameworks are released, should react-compiler-heathcheck detect strictMode? Of course, there are a lot of Next.js users. But Next.js is based on React library. I think what we write the code in React for Next.js, is that React become to depend on Next.js. So I'm wondering why this PR and #29167 are needed.

[github-actions]

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

[github-actions]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!