Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build react-html in experimental channel #30129

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jun 28, 2024

Even though the whole package is private right now. Once we publish it, it'll likely be just the experimental channel first before upgrading to stable.

This means it gets excluded from the built packages.

Even though the whole package is private right now. Once we publish it,
it'll likely be just the experimental channel first before upgrading to
stable.
@sebmarkbage sebmarkbage requested a review from eps1lon June 28, 2024 14:10
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 2:12pm

@react-sizebot
Copy link

Comparing: 0d1fdb5...04a3efd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.development.js Deleted 313.77 kB 0.00 kB Deleted 58.51 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.production.js Deleted 186.49 kB 0.00 kB Deleted 35.81 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.react-server.development.js Deleted 438.46 kB 0.00 kB Deleted 80.01 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.react-server.production.js Deleted 278.89 kB 0.00 kB Deleted 53.65 kB 0.00 kB
oss-stable-rc/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-stable-rc/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.development.js Deleted 313.77 kB 0.00 kB Deleted 58.51 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.production.js Deleted 186.49 kB 0.00 kB Deleted 35.81 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.react-server.development.js Deleted 438.46 kB 0.00 kB Deleted 80.01 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.react-server.production.js Deleted 278.89 kB 0.00 kB Deleted 53.65 kB 0.00 kB
oss-stable-semver/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-stable-semver/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable/react-html/cjs/react-html.development.js Deleted 313.79 kB 0.00 kB Deleted 58.54 kB 0.00 kB
oss-stable/react-html/cjs/react-html.production.js Deleted 186.52 kB 0.00 kB Deleted 35.83 kB 0.00 kB
oss-stable/react-html/cjs/react-html.react-server.development.js Deleted 438.49 kB 0.00 kB Deleted 80.04 kB 0.00 kB
oss-stable/react-html/cjs/react-html.react-server.production.js Deleted 278.91 kB 0.00 kB Deleted 53.67 kB 0.00 kB
oss-stable/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-stable/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-dev.js +1.03% 626.03 kB 632.50 kB +1.16% 102.32 kB 103.51 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 321.78 kB 321.09 kB = 56.87 kB 56.78 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.development.js Deleted 313.77 kB 0.00 kB Deleted 58.51 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.production.js Deleted 186.49 kB 0.00 kB Deleted 35.81 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.react-server.development.js Deleted 438.46 kB 0.00 kB Deleted 80.01 kB 0.00 kB
oss-stable-rc/react-html/cjs/react-html.react-server.production.js Deleted 278.89 kB 0.00 kB Deleted 53.65 kB 0.00 kB
oss-stable-rc/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-stable-rc/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.development.js Deleted 313.77 kB 0.00 kB Deleted 58.51 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.production.js Deleted 186.49 kB 0.00 kB Deleted 35.81 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.react-server.development.js Deleted 438.46 kB 0.00 kB Deleted 80.01 kB 0.00 kB
oss-stable-semver/react-html/cjs/react-html.react-server.production.js Deleted 278.89 kB 0.00 kB Deleted 53.65 kB 0.00 kB
oss-stable-semver/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-stable-semver/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable/react-html/cjs/react-html.development.js Deleted 313.79 kB 0.00 kB Deleted 58.54 kB 0.00 kB
oss-stable/react-html/cjs/react-html.production.js Deleted 186.52 kB 0.00 kB Deleted 35.83 kB 0.00 kB
oss-stable/react-html/cjs/react-html.react-server.development.js Deleted 438.49 kB 0.00 kB Deleted 80.04 kB 0.00 kB
oss-stable/react-html/cjs/react-html.react-server.production.js Deleted 278.91 kB 0.00 kB Deleted 53.67 kB 0.00 kB
oss-stable/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-stable/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB

Generated by 🚫 dangerJS against 04a3efd

@sebmarkbage sebmarkbage merged commit 58af67a into facebook:main Jun 28, 2024
139 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
Even though the whole package is private right now. Once we publish it,
it'll likely be just the experimental channel first before upgrading to
stable.

This means it gets excluded from the built packages.

DiffTrain build for commit 58af67a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants