Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][playground] Formatting changes to pass tabs #30151

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[compiler][playground] Formatting changes to pass tabs #30151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions compiler/apps/playground/components/Editor/Output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,14 @@ async function tabify(source: string, compilerOutput: CompilerOutput) {
}
}
let lastPassOutput: string | null = null;
let nonDiffPasses = ["HIR", "BuildReactiveFunction", "EnvironmentConfig"];
for (const [passName, text] of concattedResults) {
tabs.set(
passName,
<TextTabContent
output={text}
diff={passName !== "HIR" ? lastPassOutput : null}
showInfoPanel={true}
diff={lastPassOutput}
showInfoPanel={!nonDiffPasses.includes(passName)}
></TextTabContent>
);
lastPassOutput = text;
Expand Down Expand Up @@ -187,15 +188,15 @@ function Output({ store, compilerOutput }: Props) {
});
}, [store.source, compilerOutput]);

const changedPasses: Set<string> = new Set();
const changedPasses: Set<string> = new Set(["JS", "HIR"]); // Initial and final passes should always be bold
let lastResult: string = "";
for (const [passName, results] of compilerOutput.results) {
for (const result of results) {
let currResult = "";
if (result.kind === "hir" || result.kind === "reactive") {
currResult += `function ${result.fnName}\n\n${result.value}`;
}
if (passName !== "HIR" && currResult !== lastResult) {
if (currResult !== lastResult) {
changedPasses.add(passName);
}
lastResult = currResult;
Expand Down