Warn about legacy context when legacy context is not disabled #30297
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
kassens
force-pushed
the
pr30297
branch
2 times, most recently
from
64eb3f3 to
d74094d
Compare
kassens
force-pushed
the
pr30297
branch
3 times, most recently
from
74fa741 to
59752f7
Compare
|
Lol, quite a whack-a-mole, but tests pass now. Wish it was easier to see all the tests failing on the last run. Let me know if that makes sense, ready for review! |
| @@ -426,6 +426,22 @@ function checkClassInstance(workInProgress: Fiber, ctor: any, newProps: any) { | |||
| name, | |||
| ); | |||
| } | |||
| if (ctor.childContextTypes && !didWarnAboutChildContextTypes.has(ctor)) { | |||
There was a problem hiding this comment.
Code copied from line 392-407 above
| @@ -403,6 +403,22 @@ function checkClassInstance(instance: any, ctor: any, newProps: any) { | |||
| name, | |||
| ); | |||
| } | |||
| if (ctor.childContextTypes && !didWarnAboutChildContextTypes.has(ctor)) { | |||
There was a problem hiding this comment.
copied from line 369-384 above
There was a problem hiding this comment.
Link to docs from the error: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-removing-legacy-context?
Though the docs are missing that legacy context was also supported on function Components.
I didn't even know that before seeing the code. Not sure if it was ever broadly communicated as legacy context was deprecated around the time of introduction of function components, IIRC. |
For environments that still have legacy contexts available, this adds a warning to make the remaining call sites easier to locate and encourage upgrades.
For environments that still have legacy contexts available, this adds a warning to make the remaining call sites easier to locate and encourage upgrades. DiffTrain build for commit 378b305.
For environments that still have legacy contexts available, this adds a warning to make the remaining call sites easier to locate and encourage upgrades.