Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][repro] Test fixture for fbt whitespace bug #30394

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Jul 18, 2024

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 6:20pm

mofeiZ added a commit that referenced this pull request Jul 18, 2024
ghstack-source-id: 9918e2c81f1cb16fbe5f8df829e139cb89451a40
Pull Request resolved: #30394
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 18, 2024
@react-sizebot
Copy link

react-sizebot commented Jul 18, 2024

Comparing: b2ec044...768aad3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 768aad3

@mofeiZ mofeiZ marked this pull request as ready for review July 19, 2024 15:43
@mofeiZ mofeiZ merged commit 60cbad1 into gh/mofeiZ/12/base Jul 23, 2024
21 checks passed
mofeiZ added a commit that referenced this pull request Jul 23, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: #30394
@mofeiZ mofeiZ deleted the gh/mofeiZ/12/head branch July 23, 2024 18:24
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: facebook#30394
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: facebook#30394
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: facebook#30394
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: facebook#30394
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: facebook#30394
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 749feb2cb8026858b4c01a7405272a56c7bc382b
Pull Request resolved: facebook#30394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants