Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler][eslint] remove compilationMode override; report bailouts on first line #30423

Merged
merged 3 commits into from
Jul 23, 2024
Merged

[compiler][eslint] remove compilationMode override; report bailouts on first line #30423

merged 3 commits into from
Jul 23, 2024

Commits on Jul 22, 2024

  1. [compiler][eslint] remove compilationMode override; report bailouts o… 

    …n first line

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    686b477 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Update on "[compiler][eslint] remove compilationMode override; report… 

    … bailouts on first line"


---

Before:
- observe that both functions are compiled, even though `useFoo` is not defined using [component syntax](https://flow.org/en/docs/react/component-syntax/)
- eslint diagnostic highlights entire function body

https://github.com/user-attachments/assets/e4a26fa9-cebb-4a44-8789-4810a015a67b

After:
- `compilationMode` config is respected
- eslint diagnostic highlights only first line

https://github.com/user-attachments/assets/eb3f9b1a-b204-4f10-a920-d6fd6b821adc



[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e07e6bb View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler][eslint] remove compilationMode override; report… 

    … bailouts on first line"


---

Before:
- observe that both functions are compiled, even though `useFoo` is not defined using [component syntax](https://flow.org/en/docs/react/component-syntax/)
- eslint diagnostic highlights entire function body

https://github.com/user-attachments/assets/e4a26fa9-cebb-4a44-8789-4810a015a67b

After:
- `compilationMode` config is respected
- eslint diagnostic highlights only first line

https://github.com/user-attachments/assets/eb3f9b1a-b204-4f10-a920-d6fd6b821adc



[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f3a9dc0 View commit details
    Browse the repository at this point in the history