[compiler] patch: retain UpdateExpression for globals #30471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 24, 2024
mofeiZ
added a commit
that referenced
this pull request
Jul 25, 2024
ghstack-source-id: 2d69cb57b0947c13c41a62ab11554556c7f9e68a Pull Request resolved: #30471
facebook-github-bot
added
CLA Signed
React Core Team
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Jul 25, 2024
ghstack-source-id: 962af1e9641b46cfbd029c1885d60f8de1a35fb7 Pull Request resolved: #30471
mofeiZ
commented
Jul 26, 2024
| loc: exprLoc, | ||
| }); | ||
| return {kind: 'LoadLocal', place: identifier, loc: exprLoc}; | ||
| const binding = builder.resolveIdentifier(leftExpr); |
There was a problem hiding this comment.
This is the key change: we check if the identifier is a local (or non-local) binding
mofeiZ
commented
Jul 26, 2024
Comment on lines
+1948
to
+1972
| const identifier = lowerIdentifier(builder, leftExpr); | ||
| const kind = getStoreKind(builder, leftExpr); | ||
| if (kind === 'StoreLocal') { | ||
| lowerValueToTemporary(builder, { | ||
| kind: 'StoreLocal', | ||
| lvalue: { | ||
| place: {...identifier}, | ||
| kind: InstructionKind.Reassign, | ||
| }, | ||
| value: {...binaryPlace}, | ||
| type: null, | ||
| loc: exprLoc, | ||
| }); | ||
| return {kind: 'LoadLocal', place: identifier, loc: exprLoc}; | ||
| } else { | ||
| lowerValueToTemporary(builder, { | ||
| kind: 'StoreContext', | ||
| lvalue: { | ||
| place: {...identifier}, | ||
| kind: InstructionKind.Reassign, | ||
| }, | ||
| value: {...binaryPlace}, | ||
| loc: exprLoc, | ||
| }); | ||
| return {kind: 'LoadContext', place: identifier, loc: exprLoc}; |
There was a problem hiding this comment.
(Only whitespace changes here)
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Jul 26, 2024
ghstack-source-id: aff6606f85698ccda13d1deffb6faa9d91f9821a Pull Request resolved: #30471
mvitousek
approved these changes
Jul 29, 2024
josephsavona
approved these changes
Jul 29, 2024
mofeiZ
added a commit
that referenced
this pull request
Jul 29, 2024
ghstack-source-id: aff6606f85698ccda13d1deffb6faa9d91f9821a Pull Request resolved: #30471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):