[compiler][be] Clean up compilation skipping logic in Program #30642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 8, 2024
facebook-github-bot
added
CLA Signed
React Core Team
mofeiZ
commented
Aug 8, 2024
| return; | ||
| } | ||
|
|
||
| const environment = parseEnvironmentConfig(pass.opts.environment ?? {}); | ||
| /* | ||
| * TODO(lauren): Remove pass.opts.environment nullcheck once PluginOptions |
There was a problem hiding this comment.
Previously, we waited until compiling a function to validate environment configs. Let's just do this unconditionally -- this should be a fatal error and hopefully never happens in prod
mofeiZ
commented
Aug 8, 2024
| @@ -514,43 +486,29 @@ export function compileProgram( | |||
| externalFunctions.push(gating); | |||
| } | |||
|
|
|||
| const lowerContextAccess = pass.opts.environment?.lowerContextAccess; | |||
| const lowerContextAccess = environment.lowerContextAccess; | |||
There was a problem hiding this comment.
Now we're able to rely on the parsed / validated EnvironmentConfig, which comes with default values (instead of using a PartialEnvironmentConfig and duplicating defaults
…ram" --- Drive-by cleanup when writing #30643 [ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Aug 9, 2024
ghstack-source-id: fe2c81de9d4f41a787c690b722cbcff55eb18ac3 Pull Request resolved: #30642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Drive-by cleanup when writing #30643